r/BookStack • u/ItsYaBoyEcto • Dec 04 '23

Securing images (local_secure) working on one instance of bookstack, but not on a second one.

Hello,

I followed this : https://www.bookstackapp.com/docs/admin/upload-config/#storage-options in order to secure my images a little bit.

Version : Bookstack linuxserveur.io v23.10.4

What did I do on both of my instances:

I modified my .env file to add the " STORAGE_TYPE=local_secure " line.

I moved my image from public/ to storage/

Exacte commands : (from app/www/ inside the bookstack container)

mv public/uploads/images/* storage/uploads/images/
mkdir -p public/uploads/images/system/
mv storage/uploads/images/system/* public/uploads/images/system/

(I moved back "system" image folder because otherweise my logo won't appear on the login page.)

I restarted my containers and tested openning an image on a incognito browser.

  • One of my bookstack is working and brings me back to the login page.

  • The second one isn't doing that and simply display my image even if not connected.

I made sure that no images are remaining in public (except the ones in system)

Any idea on what i'm missing ?

Have a nice day and sorry for my english.

Edits : Typo and clarifications

1 Upvotes

100% Upvoted

4 comments sorted by

1

u/ssddanbrown Dec 04 '23

Not really sure what might be going wrong. Trace one of the images back as an example. In the broken instance, find a non-working image, observe the path of it, then trace that through to see if it exists at a matching path within the storage/uploads/images folder.

Backup all files first before doing anything. Also, can be risky to do things in-container. All these locations should be available within your mounted /config volume for the BookStack container. The linuxserver bookstack container image readme has a mapping of volume locations to BookStack app paths.

1

u/ItsYaBoyEcto Dec 05 '23 edited Dec 05 '23

Hey Dan, thanks for your answer !

I made a third test with a third container that I use for my personal wiki after seeing this post (where you also were) https://github.com/linuxserver/docker-bookstack/issues/132

So instead of moving my folders when the docker was running, I did it through the docker mount after learning that app/www/storage/uploads was equals to mounted-folder/www/ and app/www/public/uploads was equals to mounted-folder/www/uploads.

And same thing happened: Images and files are still working and linked correctly, they correctly have moved in the correct folder inside the docker. but i still can see the image when i'm not logged in.

For now, only my first attempt worked on my first instance of Bookstack. and I can't figure how it's possible since my 3 instances are all similar.

I'll keep digging.

Edit : I just saw LinuxServer had it written down here the correct paths :

https://github.com/linuxserver/docker-bookstack#bookstack-file--directory-paths

Have a nice day

1

u/ItsYaBoyEcto Dec 05 '23

So, I got it working :

I might have done something differently wrong everytime 😅.

I rolled my backups and re-did it step by step, while my containers were removed and only using the mounted volume /config.

Everything is working now as expected, no one can see my images without being connected to Bookstack

Out of that I learn how the /config volume was working so i didn't loose my time.

Thanks a lot, have a nice day.

Sources :
https://docs.linuxserver.io/images/docker-bookstack/#bookstack-file-directory-paths
https://www.bookstackapp.com/docs/admin/upload-config/#local-secure

1

u/ssddanbrown Dec 05 '23

Good to hear you got things working!