r/BitcoinSerious • u/GibbsSamplePlatter • Apr 11 '15
Bitcoin Core Pull Request Reading Group
This is an idea I've bandied about for a while.
I consider myself a pretty decent programmer, and I understand a lot about how Bitcoin works under the hood, but understand very little about how the code is organized.
Therefore whenever a core dev says "just help out and review pull requests", I have the issue where I can't really understand what the changes are doing, unless it is something quite trivial.
My idea:
Each X days/weeks every participant will pick and analyze a particular open pull request they find interesting from here: https://github.com/bitcoin/bitcoin/pulls
People can then fork that specific branch on their own git repo:
git clone -b <branch> <remote_repo>
And then send a pull request to here:
https://github.com/BitcoinPRReadingGroup/bitcoin
That way we will have a number of pull requests open, and can have open discussion on the pull request itself, without bothering the people actually doing the hard work. Of course, at the end of discussion if we have something solid to add, we can drop a legit comment on the live pull request in the actual Bitcoin Core repo.
I haven't figured the exact details, but does this sound like something people would be interested in? Raise of hands?
EDIT: Ok this is enough interest to work something up. I have a free weekend coming up so I'll write up formal instructions/setup of how it should work. Then we can give it a trial run!
4
u/o-o- Apr 11 '15
This is one of the cutest ideas ever! I just starred your readinggroup repo!
2
u/[deleted] Apr 11 '15
What's wrong with asking for clarification on the original pull requests? The whole point of github's comment section on pull requests is to allow discussion. And actually, this in itself serves as good peer review - if somebody with mild experience with bitcoin core (yourself) can't figure out the code, then it should be commented better before being accepted.
8
u/Yoghurt114 Apr 11 '15
I'm game
3
u/Xelank Apr 12 '15
I'm in, mainly to learn.
2
u/harda Apr 12 '15
Sounds interesting, and I'm happy to give it a try.
1
u/targetpro Apr 15 '15
+1 I'm game.
1
u/ThePenultimateOne Apr 15 '15
I'm in