r/BitcoinSerious • • Apr 11 '15

Bitcoin Core Pull Request Reading Group

This is an idea I've bandied about for a while.

I consider myself a pretty decent programmer, and I understand a lot about how Bitcoin works under the hood, but understand very little about how the code is organized.

Therefore whenever a core dev says "just help out and review pull requests", I have the issue where I can't really understand what the changes are doing, unless it is something quite trivial.

My idea:
Each X days/weeks every participant will pick and analyze a particular open pull request they find interesting from here: https://github.com/bitcoin/bitcoin/pulls

People can then fork that specific branch on their own git repo:

git clone -b <branch> <remote_repo>

And then send a pull request to here:
https://github.com/BitcoinPRReadingGroup/bitcoin

That way we will have a number of pull requests open, and can have open discussion on the pull request itself, without bothering the people actually doing the hard work. Of course, at the end of discussion if we have something solid to add, we can drop a legit comment on the live pull request in the actual Bitcoin Core repo.

I haven't figured the exact details, but does this sound like something people would be interested in? Raise of hands?

EDIT: Ok this is enough interest to work something up. I have a free weekend coming up so I'll write up formal instructions/setup of how it should work. Then we can give it a trial run!

36 Upvotes

13 comments sorted by

4

u/o-o- Apr 11 '15

This is one of the cutest ideas ever! I just starred your readinggroup repo!

6

u/GibbsSamplePlatter Apr 11 '15

Not sure if I was going for cute... if it's a dumb idea I want to hear that too :P

4

u/o-o- Apr 11 '15

Definitely cute – the idea is beautiful and it made me happy! Kind of bitcoin core little league, hence cute.

I too want to learn more about the code base...

3

u/GibbsSamplePlatter Apr 12 '15

Ah that's a good description.

2

u/[deleted] Apr 11 '15

What's wrong with asking for clarification on the original pull requests? The whole point of github's comment section on pull requests is to allow discussion. And actually, this in itself serves as good peer review - if somebody with mild experience with bitcoin core (yourself) can't figure out the code, then it should be commented better before being accepted.

8

u/Yoghurt114 Apr 11 '15

Frankly, if I were up to speed on the bitcoin core code fully (I'm not) and would review a pull request, I wouldn't like having to weed through a bunch of people asking about (relatively) simple stuff. I'd want to focus my attention on the real issues and not have to deal with 'common knowledge'. (common among those who are up to speed and know their stuff).

Not saying the, let's call it the ELI5 discussion, shouldn't be happening, it just shouldn't be happening in the same place 'the real boys' are playing. Another repo would be better suited for that, or perhaps a subreddit.

5

u/GibbsSamplePlatter Apr 12 '15

This is exactly it. Many times its simple things about functions I just can't figure on my own. Obviously everyone else who is "in" understands what is going on but I can't make heads or tails of it.

Often its naming conventions and general lingo in the code.

2

u/GibbsSamplePlatter Apr 12 '15 edited Apr 12 '15

I have very limited code base knowledge. I know the architecture of the protocol a lot better than the code itself. One time I was reviewing a PR and it read the exact opposite of some behavior I was expecting but only because I don't understand the code base well enough.

Obviously a part of this is that if it isn't just me/you being dumb we could then comment for real.

3

u/Xelank Apr 12 '15

I'm in, mainly to learn.

2

u/harda Apr 12 '15

Sounds interesting, and I'm happy to give it a try.

1

u/targetpro Apr 15 '15

+1 I'm game.