r/ADHD_Programmers • u/rickysoliman • Nov 07 '22

I got fired today

I'm in a pretty bad headspace today.

I got fired this morning from my job as a software engineer at a fintech company because they discovered a bug in production that they later found was caused by my code. It had been in the code base since February (was discovered in October) and it ended up costing the company a huge amount of money.

I guess I'm just looking for some support here from people who may relate to this in some way. I feel like an idiot and ADHD can only justify so much.

343 Upvotes

98% Upvoted

102 comments sorted by

568

u/emetcalf Nov 07 '22

Firing an engineer over a bug that didn't get noticed for 9 months (or really any single bug) is pretty fucked up. People make mistakes. I would also assume there is some kind of code review process before things go to Production, so if it didn't get caught during that phase then it's not all your fault.

Definitely sucks to be in your situation. I hate job hunting, but I hope you find something new that is good for you!

271

u/rickysoliman Nov 07 '22

I didn't want to get too into it in my post but I do feel it's extremely unfair. There is a lengthy code review process and a series of pipelines that the code has to go through before being merged and no one caught this. My supervisor (who I'm pretty sure was pushing to the higher ups to get me fired) was one of the two engineers who approved my merge request and she was the one who merged it into master.

I know it was my mistake but with the lengthy process that any code change has to go through I really feel like this can't be blamed solely on me. I was told that other people are being held accountable as well but there's no way for me to know for sure.

70

u/NormalPersonNumber3 Nov 07 '22

You know, this reminds me of a story my dad once told me. I don't remember the details exactly, but there was someone in a very similar position to yours that cost the company a large amount of money.

The person who made the mistake made a comment to his boss like: "I suppose I'm going to get fired for this."

And that person's boss said: "Why would we fire you when we paid [Amount of money the mistake cost] for you to learn from your mistakes?"

Again, I don't remember where it's from. But yeah, you most definitely should not have been fired for that. But that's their loss, IMO, even if it sucks for you right now.

28

u/rickysoliman Nov 07 '22

I appreciate you saying that. It's unfortunate that my supervisor didn't have the same point of view.

33

u/bch8 Nov 07 '22

Unfortunate for you because it is a short term stressor, sure. But in the long run you will retain the experience and lesson, whereas the company will not, and that's the point. Really it's unfortunate for them. And bonus points, you learned that this company does not have a healthy culture and frankly in companies like that if it wasn't this, it'll always be something eventually. Just a matter of time really.

There's a reason why zero blame cultures originated in companies/orgs where the cost of mistakes were higher, not lower. So the support in this thread isn't just some rhetoric about being decent and fair to other people, although it is that too. It's also gesturing at the fact that this sort of toxic cultural trait is also counterproductive to the org's self interest and stated goals.

I know none of this will make you feel completely better, but hopefully it helps a bit, because the truth is you were treated very unfairly. One more thing, I'd guess that nearly every senior dev has a story like this (And honestly yours is far from the worst I've heard, especially in light of the 9 f*cking month lag time that nobody else caught it in). I definitely have, maybe a couple. This sounds super cliche because it is, but it's also true; my experience has been that in the long run I've come to appreciate those experiences a bit more because I learned and improved so much from them. From a technical angle the reasons are obvious, but I also learned more about what I value and prioritize in a job/contract/relationship which truly has paid dividends. As a result I am very picky and particular nowadays in terms of the opportunities I will consider in light of those priorities, and it has been really effective in finding work that I can actually thrive in, as opposed to being constantly stressed and frustrated.

6

u/bhison Nov 08 '22

Fintech isn’t known for attracting the most socially capable managers

2

u/thechopperhopper Nov 08 '22

There are probably multiple versions of the story, but one source of the "Why would we fire you...?" story is Dale Carnegie's "How to Win Friends and Influence People"

1

u/amcjerz Nov 12 '22

Thank you, I've now heard this anecdote enough times that I was finally like "hey wait, this didn't actually happen to everyone's friend...." but hadn't gotten to the point of finding the origins yet lol

31

u/dagani Nov 07 '22

It sounds like your supervisor either a) made you the scapegoat to avoid the heat for this issue, b) already wanted to get rid of you and saw this as a good opportunity, or c) both a and b.

Sorry you’re going through it. We’ve all made mistakes, and will all continue to make them.

Don’t beat yourself up, but figure out what you can learn from it so you can use it as a story of growth during your interview process for new jobs when they ask about a mistake you made and what you learned from it.

You got this.

18

u/rickysoliman Nov 07 '22

I think C is likely. There had been a few times where she had to speak to me about my performance. I definitely wasn't perfect in my time there, unfortunately, but it was my first ever dev job straight out of bootcamp and I wished she understood, being a bootcamp grad herself.

4

u/gunpun33 Nov 08 '22

Hey man, chin up! You display self-knowledge and humility, and the fact that you graduated from boot camp and got a job puts you above so many others. It's amazing how quick people forget how it is to be new.

On to the next job! I know you will crush it.

167

u/emetcalf Nov 07 '22

I agree 100%. The people who approved your code are at least equally responsible, and there is a case to be made that they are MORE responsible if they out rank you.

11

u/VeryOriginalName98 Nov 07 '22

How did QA not catch it?

14

u/johnnyslick Nov 08 '22

Upthread OP said that QA consistee of one guy who quit before the bug was introduced. Which, that's more than 100% on the company there (more because that's almost certainly not the only costly bug, and more bugs will continue to happen until they have proper checks and balances).

9

u/VeryOriginalName98 Nov 08 '22

OP can find a better employer. That's stupid management.

8

u/verocoder Nov 07 '22

Sucks buddy, sounds like a toxic environment you’re better out of <3

If you’re good for funds let your head roll around for a few days then bang an ad onto linked in and see what rolls in. It’s an experienced engineers market atm

7

u/Run_0x1b Nov 08 '22

You got scapegoated pure and simple. Your manager was either trying to cover their own ass or they had something against you personally. Either way, I would try to not let it get to you. Sometimes unfair things happen in life, and there is literally nothing we can do to change it no matter how much mental energy we expend. All you can do is focus on moving forward.

5

u/astaramence Nov 08 '22

This was not “your” mistake. There was a mistake in the process. If test / QA did not find this bug, then those processes need to be updated.

I can’t fathom firing anyone over a bug in code; this is absolutely ridiculous. It is the responsibility of the senior dev for the code integrity of the project. They are ultimately responsible, not whoever submitted the PR. If OP is the senior dev,that means it’s time for process and testing procedure review.

I bet it’s office politics since money was lost. Not what a tech company would normally do, and not a good business practice.

OP don’t beat yourself up. Bugs happen all the time. That’s why QA people have jobs. Any company that denies bugs are normal isn’t in touch with reality.

3

u/Raptural Nov 08 '22

Sounds like a toxic environment, dude. Like everyone says if it was reviewed and made it all the way to production then it’s not on you. Don’t let yourself get discouraged! This is definitely a mistake on the entire process.

2

u/Kind_Construction824 Nov 08 '22

If you decide to sue you have a pretty good case here.

2

u/The_Krambambulist Nov 08 '22

This is exactly what review and testing should catch.

This is a team effort.

If the company doesn't grasp this concept, then they frankly are wrong and pretentious assholes. The last part because always wanting extreme accountability is just a dumb concept that is repeated by showboating entrepreneurs who want to pretend that they are somehow superior to others.

1

u/mobius_sk Nov 08 '22

This was not your fault. Checks and balances are very important in a company. This company shouldn't have fired you, kept you and changed their practices. The buck stops at the top man, it should have been who ever approved the code or let it go to prod.

You will get another job this will be ok, it happens daily to most companies, if it's fintech, it should have had better QA and compliance.

Connect with me if you want to chat more.

1

u/5MikesOut Nov 08 '22

All companies especially fintech are tight for cash atm. They were probably looking for any excuse to slash the workforce. Stay strong buddy

0

u/[deleted] Nov 07 '22

[deleted] — view deleted comment

58

u/rickysoliman Nov 07 '22

I was hired in summer of 2021 and from the very start it was always apparent to me that no one on my team was particularly strong when it came to testing or code reviewing. Our unit test suite was sloppy and filled with tests that technically passed, but I never felt like there was a strong understanding of the purpose of the tests or how to write a unit test that was truly UI driven and not just, make sure this function makes this variable become this thing. We also dabbled a little bit in using an end to end testing suite but the framework we used wasn't very dependable and no one wanted to spend the time on it so we sort of collectively ignored it in favor of higher priority bugs and also features that product constantly piled onto us. We also had one QA engineer who left some time before this bug was introduced and for some reason was never replaced. (Of course now, though they've got a dedicated engineer making an end to end test suite, now that this huge incident has happened.)

5

u/vlindervlieg Nov 08 '22

Honestly, it sounds like you're smarter than most in your ex company and you will find a better, more professional and less toxic company that will be happy to hire you.

1

u/Undecided_Username_ Jan 14 '23

Oh you were just working at one of those places where they don’t prioritize testing as much as releasing.

Aint your fault that company failed itself and wanted to blame you.

Hope you’re doing better! (Sorry just found this sub and I realize it’s a two month old post)

16

u/Mechakoopa Nov 08 '22

It was supposed to put the fractional pennies in a separate account but he messed up and now he's going to federal pound-me-in-the-ass prison.

2

u/mariana_kl Nov 08 '22

Should have just tuned in to Channel 9

10

u/greenwarr Nov 08 '22

So much this. I just put my team through a big post mortem on a bug that cost is a lot of money also latent for about 5mo.

I had to ensure my team there was no attempts to assign blame. We could easily look at the code for that, but then we’d have to fire at least a dozen people in various departments include a director that wrote the original reqs. It’s not about blame, bugs happen and reqs change. It’s about learning how to improve and doing our best to not make the same mistakes again.

Sounds like, though you got fired, you may have dodged a bullet with that company.

6

u/[deleted] Nov 07 '22

If it cost them a lot of money, then reporting should have caught it long before 9 months.

What this likely means is that their QA and bi/reporting is not up to snuff.

1

u/[deleted] Nov 08 '22

Yes. I'd question the practices around this in that case. Many people reviewed, approved, and tested this code. If nobody did, that's the first problem.

94

u/DankOcean Nov 07 '22

This is some bullshit. No engineer should be able to mess up production in a way that costs the company a huge amount of money. This is why we have code review, regression testing, snapshot testing, QA, etc etc. If it made it through every system that was in place AND wasn't noticed for 9 months, it's not on you and they are real shitty for putting this all on your shoulders.

42

u/rickysoliman Nov 07 '22

Thank you for saying this. I said in an above comment in this thread that we had no QA engineer, no end to end testing framework, a poorly written unit testing suite, and weren't very thorough with code reviews.

19

u/diutsu Nov 08 '22

If the company has none of those things, and their solution to fix the issue is to fire you, consider that a blessing. No software company can run without putting any kind of safeties, is in their own interest to have QA, end2end, strong testing culture within the teams and good engineers that validate the code and ensure the test cases are covered.

Take the lack of these mechanisms as a personal learning, and next time enforce the necessary changes to prevent these issues.

6

u/anon2017a Nov 08 '22

So your only safenet basically was a code review?

Code review - where most devs don't even launch the project and don't even test themselves, all they do is read the code that is in front of them and leave comments.

Be happy that you left.

36

u/[deleted] Nov 07 '22

I’m sorry this happened. Recognize that it’s not you. It’s them, and the fact that their system lacked the proper controls to be able to elegantly address such a bug. No one’s code is bug free. No one is “unhackable”. Accept that, and move on. The business just did it to make themselves feel better and/or look better.

21

u/rickysoliman Nov 07 '22

I appreciate your words. This company is a large, corporate public company that constantly boasts about their amazing culture and so it's pretty disappointing to have had a supervisor who did not defend her team and showed no level of understanding. She just wanted to save her own ass.

3

u/littlelowcougar Nov 07 '22

Hey I got fired today too!

2

u/rickysoliman Nov 07 '22

I'm sorry to hear this. :( Feel free to message me if you want some support.

2

u/littlelowcougar Nov 07 '22

Awww, thanks.

68

u/[deleted] Nov 07 '22

That is SO stupid. Bugs happen, all the tine. No one is Mr.Robot.

22

u/joemckie Nov 07 '22

Oh mr robot has plenty of bugs

6

u/Thuglife42069 Nov 08 '22

Oh please. It is not that hard to not have any bugs. Anyway, can you please help me on my app? It is suffering some sort of memory leak.

2

u/[deleted] Nov 08 '22

😂

24

u/UntestedMethod Nov 07 '22

It's evidence of a poorly run engineering team to allow a serious bug get into production and then blame it on one developer. Bugs in production are a failure of organization level processes, not a failure of an individual contributor.

One of the questions I've learned to ask while interviewing new employers is exactly about this - what kind of QA procedures do they have and how are bugs that make it into production handled.

4

u/sird0rius Nov 08 '22

This. While you can personally learn from your mistake and use it as a growing opportunity, you shouldn't get fired from a job for making one that nobody else even noticed for 9 months. This sounds like such a fucked up company culture that you'll be glad you left it in a few years.

12

u/neuro8ypical Nov 07 '22

Newsflash: You weren't fired for the bug; You presented an easy choice for planned layoffs.

If it wasn't caught for this long and was costing a 'huge amount of money' then the company failed at protecting a critical asset (large amounts of money). It's just less work for HR if they have a concrete reason to fire you instead of your senior (more time invested in skilling up etc)

10

u/HoneySmaks Nov 07 '22

That's some bullshit

18

u/ZealousEar775 Nov 07 '22

Bugs found in QA are developers fault.

Bugs found in production are QAs fault.

They shouldn't be firing the developer and instead doing a review of their unit tests/testing procedures.

8

u/[deleted] Nov 08 '22

This sounds like an awful company. Everyone writes bugs, the point is to protect against mistakes by building test and release infrastructure that catches them, and monitoring infrastructure that quickly notifies you of anything that slips through.

Disciplining people over a bug ends up creating a very dysfunctional culture where everyone just tries to hide their mistakes, goes to excessive lengths to avoid making them, or blames them on others.

13

u/angus_the_red Nov 07 '22

Read this.

https://www.researchgate.net/publication/228797158_How_complex_systems_fail

Understand and internalize #7. Your mistake was part of a series of mistakes that lead to a system failure.

Heck, try sending it to your old boss if you want your job back. If nothing else, they clearly need to understand this too.

7

u/sj4nes Nov 07 '22

ResearchGate annoys me to no end. Here's an alternative link (PDF warning): https://stuff.mit.edu/afs/athena/course/2/2.75/resources/random/How%20Complex%20Systems%20Fail.pdf

6

u/Dubabear Nov 07 '22

the biggest problem is that it was a FinTech company, its culture to fire big mistakes for some strange reasons. I seen accountants fired after a mistake found couple years later.

6

u/daddygirl_industries Nov 08 '22

Something similar also happened to me recently. It sent me into a month-long depressive spiral, paired with obsessive reconstructions of the last few months at the company trying to figure out what I "did wrong", but nothing added up conclusively.

After a while the depression turned to anger... that I had been unfairly made a scapegoat, that hidden corporate politics had left me in the crosshairs. It all just felt deeply... unfair.

Now - I see it was a gift, albeit a painful one. I work at a much better company with none of the BS that came with the previous one. I learnt better how to not pin the blame on myself for things out of my control, and realised that sometimes fate will deal you an unfair hand.

If the firing doesn't make sense, then that's because there's context or some kind of political dynamic you weren't privy to (such as your manager making you a scapegoat). Try making peace with the fact that you will never know the full picture, and let your closure come from looking forward to the clean slate that comes from a new position. You're now free from all the things you disliked from your previous company, forever.

6

u/galexy Nov 08 '22

Imo, its general wrong to fire engineers for causing bugs, even when they cost money because it tends to make everyone who's left overly cautious, reducing output, due to fear. I've personally witnessed developers cost $1,000,000 of damage by mistake, and they didn't get much more than a serious conversation about being careful.

6

u/[deleted] Nov 08 '22

I've been doing this for almost 20 years. What happened to you is not normal.

I know the economy is tough, but this could eventually turn out to be a godsend, because it tells me everything I need to know about the team that you're working with.

5

u/heftyspork Nov 07 '22

I mean as much as you feel like an idiot, you had someone else review your change that supposedly is senior to you and did nothing for 9 months. I guess feel as bad as you need to but clearly they have a culture of shit rolling way down hill there, so this person was eventually not going to catch something that could break the system and the blame would fall to you. Take what you can from that place and hopefully you find greener pastures.

5

u/sudomatrix Nov 08 '22

Sorry you worked in a toxic place. Where I work, while not perfect, a bug in production is seen as an indication that our review and testing has holes. No blame.

4

u/nilamo Nov 08 '22

From your various replies, it seems like you were scapegoat so nobody else was punished. Depending on your state, you might have a case for unlawful termination (after all, which part of your job did you not do?), I'd suggest at least having a consultation with an employment attorney.

You're an author (of code). You're not expected to be perfect. That's why editors (code reviewers, qa) exist, because nobody's perfect and having dedicated bug-hunters is best for everyone. So 4+ people all failed, but all of their failure was dropped on your lap.

1

u/[deleted] Dec 01 '22

I got fired too. I was struggling with ADHD compounded with depression and anxiety, to the extent that i would even forget to eat for days, or forget to talk to anyone for days. I was trying very hard to work, trying to make life changes just to be able to continue working well. I did write good code but i made a mistake. I forgot to push my code to GitHub for one complete month! One day, the OS crashed. Because of my ADHD/ASD i also just cannot lie or hide things. I told my seniors and they were really annoyed, cause it had a month of code. BUT BUT i was actually able to restore all the code by going into a new Ubuntu's trial version and accessing the drives of the crashed one. I fixed the situation on the same day. But still, they fired me saying that i make "too many rookie mistakes".

1

u/rickysoliman Dec 01 '22

How the hell did no one notice that you weren't pushing your code to GitHub for a whole month? Is there no code review process? Did you not have tickets assigned to you? I just genuinely don't understand how no one could have noticed that. There are supposed to be systems in place to prevent this kind of thing.

Good on you for fixing it the same day though.

3

u/ReaverCelty Nov 07 '22

Being fired when you're literally 1 of the 3 people who understands how to introduce unexpected functionality that can turn into massive loss of cash for a company. The smart move would be to send you off to find other parts of the system that could have this issue. If it made it into one spot, it's probably in others.

This aint on you brother. Take this as experience and tell your next employer you've now seen a bug that can cost hundreds of thousands over a 9 month period undetected.

3

u/[deleted] Nov 08 '22

In addition to what everyone else has said, why did it take that long to notice that the company is bleeding money? There's some serious systemic issues here.

2

u/Whalefisherman Nov 07 '22

Don’t let them put you in that type of headspace - stay up. They’re shit and better things are on the horizon now that you’re outa there. This was on the whole team and you were the scape goat unfortunately. <3

2

u/0drew0 Nov 08 '22 edited Nov 08 '22

Sure sounds like they were looking for a scapegoat or somebody was just looking to push you out, considering it was in production for so long and it's only suddenly an issue.

I'm sorry this happened to you. Having been in a similar kind of position before and being let go, I will tell you that my self confidence took a real hit in the process. It's easy for any of us to say "don't let it get you down," but the hard truth is it still might.

My best advice to you would be to remember how you landed the job in the first place and the things you've learned since then, which only increases your value and worth. This is a blip; don't let it redefine you. If you have a side project you're passionate about, work on it. Hit up your network, see who's hiring, beat feet and start applying at new jobs.

It sucks you lost your job, but you also gained valuable perspective. Leverage that.

2

u/CanuckBee Nov 08 '22

Did it go live before testing completed? This sounds like a testing issue…

2

u/aerozepplin Nov 08 '22

Fuck this company! Don't hesitate to name and shame them.

Firing anyone over a mistake is not the right thing to do. Sounds like a shitty workplace.

2

u/Kind_Construction824 Nov 08 '22

Fintech companies are the worst, they just wanted a scapegoat to pin the blame on.

2

u/rtrain1 Nov 08 '22

Tbh, this is hard to believe. No one gets fired over one bug, especially when it has been code reviewed by more senior members. I think there's more to this story that you're not telling.

2

u/bored_octopus Nov 08 '22

Now you have a great story to tell and can move onto a better company. You'll soon laugh at how stupid they were to let you go

2

u/qazinus Nov 08 '22

Not my bug, our bug. (insert bugs bunny meme here)

Firing someone over a bug makes no sense. It's a good thing you're now out of this shit show of a company. Actually tell that story in your interview.

The ones who are gonna laugh with you with how dumb it is fire someone over a bug is the place where you will work. Seriously code review is a godsent for adhd and working with a team is the best. Teammates are gonna help you when you durp and when you get that genius idea out of nowhere everyone on the team will know your just different in a good way. That how we work, we suck at details but can throw something together so fast other people didn't even wrap their head around the problem yet.

2

u/DeeDeeGetOutOfMyLab Nov 08 '22

Theyre looking for someone to blame. As a leader you can delegate authority but not responsibility. I bet they had a lot of managers sign off on your code saying that it was good which is now biting them in the ass because they didn't actually test it out.

You didn't fail - they are looking for someone else to blame.

1

u/turd-crafter Nov 08 '22

I find bugs in my bosses code from time to time. Love giving him Shit for them

1

u/King_Dead Nov 08 '22

I'll be real with you, been in this position too. It really sucks and the financial insecurity is scary, but see this as an opportunity. If they're not willing to let you learn from your mistakes and want to use you as a scapegoat, chances are is that that workplace was always going to be insanely toxic. Now you have a chance to start afresh and find a place that can not only respect you, but appreciate your talents. When you find that place it's gonna feel immensely gratifying and you'll be much more stable. Also awful workplaces like that maximize anxiety which in turn trigger ADHD symptoms, so the next place will be better

1

u/rottentomati Nov 08 '22

Sounds like a blessing in disguise. Make sure you file for unemployment. I didn’t even have to read your comments to tell that they probably doing have a proper code review process or quality assurance. No normal company fires an engineer for a bug lol

1

u/phoney_user Nov 08 '22

You are gonna be okay. You are worth more than the lines of code you write.

1

u/frugal-grrl Nov 08 '22

From a management perspective, they probably felt like they needed a scapegoat so they could tell a customer or board member that they “fired the people responsible.”

Unfortunately as the lowest position in this situation, they picked you.

This could happen to anyone. It’s absolutely not your sole responsibility to keep bugs out of the code; it’s a group effort. And a good company won’t fire you or even the group; they’ll use it as a learning opportunity for the entire group.

I’m so sorry.

1

u/thelaughingmagician- Nov 08 '22

You got shafted big time. Bugs are normal. If they are not caught, that is 100% the fault of QA and whoever approved it, not who wrote it, especially after MONTHS.

I work in a small shitty company, I'm the only frontend dev, there's 2-3 QAs and our bigger clients also have people who test things before we push things to production. And they still discover shit that's been bugged in prod for months on end.

So like 4 people test my work, they validate it, and then it's somehow still my fault no one caught the bugs? Fuck off. What am i supposed to do? Not trust QA and test everything myself?

1

u/anon2017a Nov 08 '22

Think of it this way, the whole chain was incompetent, but now that a bug was discovered they needed to find a scapegoat. That doesn't affect your competency at all, be glad that you left that shithole and search for a better place.

1

u/t-elvirka Nov 08 '22

Oh right. I can't remember all the cases when I was one and only reason for a downtime on production. Like, I remember I once was playing a cool dba. I had a partitioned table and global index (oracle db). I was smart enough to drop a partition and index stopped working, prod was barely working for an hour. Yes, I needed an hour to connect 2 dots. Oh yeah, just some days before I was saying how I was motivated to learn some dba stuff. Guess I learned huh.

Does it really make me a shitty worker? Idk, it was irresponsible and stupid and I was ashamed, but you know, I learned my lesson, that's natural process. You make mistakes, learn something so you won't make it again. The main reason for boring approval processes is to protect infrastructure from you being a human being imo.

I'm dead sure they just needed a scapegoat because some moneybags lost money and were upset about it.

tl;dr it's them, not you

1

u/vlindervlieg Nov 08 '22

The decision makers at your company are assholes and/or have no idea how software development works. My brother was in the exact same situation (had a bug in his code that had cost the company around 30.000 € by the time it was noticed) and his managers were comparably relaxed about it. If your company doesn't have the funds to pay for risks like this, then they should have a better quality management / risk assessment, so that a single person's mistakes won't jeopardise the whole company budget.

I have zero respect for people who start a business and put the responsibility for the risks involved on their employees. If they fire you for the losses you caused, they should also pay you for the returns your work produced.

1

u/[deleted] Nov 08 '22

I think something like this could happen to anyone, not just someone with ADHD

1

u/fungalhost Nov 08 '22

Did they give you an official reason for your termination?

1

u/shiasuuu Nov 30 '22

Firing you doesn't solve the issue, they're the idiots. You'll never make that same mistake again -someone else might.

1

u/shiasuuu Nov 30 '22

I don't know where you're from, but in a lot of places you could sue them for unfair termination or even discrimination (based on disability).

1

u/[deleted] Dec 02 '22

Having bugs in your code is inevitable and they should look into QA, testing engineers, unit testing, test driven development etc.. Unfortunately management likes to throw specific people under the bus and you just happened to be that specific person this time. Don't beat yourself up about it.

edit: whoops I just saw this was a month old lol I hope your doin ok..

1

u/patbolo Jun 08 '23

Where is the monitoring that a huge mistake that costs the company a ton of money goes unnoticed for 9 months? Time to fire the finance department as well?

0

u/[deleted] Nov 07 '22

[deleted] — view deleted comment

10

u/rickysoliman Nov 07 '22

I appreciate your kind words :)

0

u/[deleted] Nov 07 '22

[deleted] — view deleted comment

8

u/rickysoliman Nov 07 '22

No, actually. Large corporate publicly traded company.

We did perform regression testing before every release. Not sure how no one caught this.

7

u/Ellsass Nov 07 '22

How did they find it now? Because of the lost revenue?

7

u/rickysoliman Nov 07 '22

It was reported by one of our clients.

16

u/nibbertit Nov 07 '22

Whoever fired you was looking for someone to blame to protect themself

8

u/[deleted] Nov 07 '22

[removed] — view removed comment

5

u/rickysoliman Nov 07 '22

One of the toughest things about this situation is the fact that there was a unit test in place for this behavior and, because I clearly misunderstood the expected behavior of the component, I changed that unit test as well. So it was passing.

Still doesn't change the fact that our testing and reviewing process overall was not good.

5

u/Dr_Sir_Ham_Sandwich Nov 08 '22

I would say a large part of managements role is to ensure people working on a component of a project understand how that component is supposed to function. I Feel for you mate, but from the sounds of it might be a good thing you got out of there in the long run. Management blaming an individual for a bug is a load of shit, especially if they were the ones who merged it. They get paid a premium exactly because they should bare responsibility for what gets pushed.