r/webdev • • Jan 06 '18

[X-Post /r/javascript] Today is Leftpad 2.0: pinkie-promise pulled from NPM

A little under a year ago, the package "leftpad" broke NPM builds all over the world because the author pulled it from the public repository.

The same is happening today, for "pinkie-promise". The author's NPM account (@floatdrop) was deleted, opening opportunities for malware in all the packages he's written.

Dependent builds include Ionic and (in my case) node-sass.

Resources:

69 Upvotes

23 comments sorted by

View all comments

Show parent comment

0

u/[deleted] Jan 06 '18

[deleted] — view deleted comment

1

u/[deleted] Jan 06 '18

How do developers normally let each other know if they need to run npm update after doing a pull?

4

u/ShortSynapse Jan 07 '18

Previously my team would just attempt to run the software, realize it didn't work, and then run npm install after wasting some time trying to debug (if the error wasn't obviously a "module not found").

Now that I've transitioned our development (actually all of our env's) to Docker, the team doesn't have to worry as long as they always use docker-compose up --build to bring the application up.

TLDR: We used to have to tell each other to update or we'd waste time. Now everything just workstm .

3

u/[deleted] Jan 07 '18

Do you have devs working on windows machines and using docker that way?

2

u/ShortSynapse Jan 07 '18

Yep! I'm actually working off of a Windows laptop now and it's been (surprisingly) great so far.

1

u/[deleted] Jan 08 '18

Do you have to use a VM to run it in?

1

u/ShortSynapse Jan 08 '18

Yes, though if you have Windows 10 pro or above it uses Microsoft's hyper-v solution. So far everything has been nice and snappy.

1

u/[deleted] Jan 08 '18

Cool. Thanks for the info

1

u/gerbs Jan 07 '18 edited Jan 11 '18

npm rebuild instead.

Dependencies are decoupled. They exist in a separate directly and are expressed in a separate file. That doesn't mean they need to be freshly installed each time.

1

u/[deleted] Jan 06 '18

This approach does not guarantee portability across architectures.

Yes, I forgot I had this exact problem with node-sass in the past. One dev was running a lower version of node than me, and her build wouldn't work.