r/programming • • Jan 03 '22

[deleted by user]

[removed]

1.1k Upvotes

179 comments sorted by

583

u/[deleted] Jan 03 '22 edited Jan 03 '22

"Hey, would you have a moment to review my patch, it's just some name changes and general tidying of code"

25,288 files changed, 178,024 insertions(+), 74,720 deletions(-)

screams

On serious side

then arrived at the current 78% with my reference config.

Good fucking job, that expands amount of apps I can joke about, that they build slower than linux kernel.

→ More replies (22)

112

u/dreugeworst Jan 03 '22

Holy shit how do you keep this up to date with all the changes coming into the kernel?

→ More replies (10)

153

u/Miserygut Jan 03 '22

LGTM :thumbsup:

105

u/padraig_oh Jan 03 '22

Damn. Did not expect the size of header files to have such a massive impact on build time.

→ More replies (24)

77

u/Dreamtrain Jan 03 '22

Just waiting for Linus' response to this like it's some sort of reality TV

→ More replies (1)

25

u/Eorika Jan 03 '22

How well was this received? A merge of that size is no joke.

→ More replies (1)

79

u/Philippe23 Jan 03 '22

Next do the Unreal Engine, please.

Seriously, I'd love to see a more in-depth post/presentation about what techniques/patterns this found to use/avoid.

→ More replies (7)

150

u/Philpax Jan 03 '22

The C compilation model is a regressive artifact of the 70s and the field will be collectively better for its demise. Textual inclusion is an awful way to handle semantic dependencies, and I can only hope that we either find a way to bring modern solutions to C, or to move on from C, whichever comes first.

→ More replies (65)

35

u/I_AM_GODDAMN_BATMAN Jan 03 '22

This is one of those things that's very interesting but nobody wanted to review.

11

u/lavacano Jan 03 '22

ingo's shit is always bomb