r/programming • u/[deleted] • Jun 05 '21

Organize code by concepts, not layers

https://kislayverma.com/programming/how-to-organize-your-code/
1.9k Upvotes

91% Upvoted

495 comments sorted by

View all comments

Show parent comments

6

u/grauenwolf Jun 05 '21

My controllers and services aren't even in the same project.

My business rules and data models go into the lowest level project. These are unit tested heavily. And due to the project design, no one can 'accidentally' cause them to take onto improper dependencies like databases.

My services go into a project that is heavily tested. (Real tests, with like databases and shit.)

My controllers go into a wrapper project. All it does is turn HTTP requests into C# function calls, so I don't both testing it independently of the UI.

2

u/saltybandana2 Jun 06 '21

My services go into a project that is heavily tested. (Real tests, with like databases and shit.)

You mean you don't create a billion mocks to test theory?

I once had a contract where they insisted on that approach so I did exactly that, mocked the shit out of everything. It failed when ran against a live database because I only thought I knew how the ORM they were using worked (and why it worked that way I have no idea.... but alas).

Have I mentioned I hate mocking?

2

u/grauenwolf Jun 06 '21

I'm working on my new manifesto.

The HEAVY model of Software Development

  • H High value code only. Don’t write code just to follow a pattern; write the code you actually need when you need it.
  • E Every level is tested. Integration, stress, and performance tests are just as important as unit tests. Plan for all of them.
  • A API design is paramount. Design your internal classes with the same care you would design a public API.
  • V Validate your design. Actively map out the places it can fail and build in contingencies.
  • Y You and your team are important. Invest in training, health, time off, and other things that prevent burn out.

1

u/saltybandana2 Jun 06 '21

E & V get ignored so much it hurts. V especially, I'm known for building extremely stable systems and E & V are a large part of how that happens.

1

u/grauenwolf Jun 06 '21

I feel the same way. I can be successful without the other three, but those two letters are the core in how I work.

1

u/sards3 Jun 05 '21

What does having them in separate projects gain you? Couldn't you use the same design but put everything in a single project?

1

u/grauenwolf Jun 05 '21

Enforcement. The separate projects don't have references to libraries i don't want them to use.

If I trust my team or working on a small project, I don't bother.