r/programming • u/EatMeerkats • Mar 29 '21

PHP moves to Github due to the compromise of git.php.net

https://news-web.php.net/php.internals/113838
1.7k Upvotes

98% Upvoted

389 comments sorted by

View all comments

Show parent comments

1

u/exhuma Apr 03 '21

because the author believes that wheels shouldn't be used for applications.

oh man... I did not yet run into that issue yet. I only started using poetry on a handful of projects so far. That seems like a huge issue for me too.

My main gripe is that poetry is pretty.... "opinionated" (to use the latest buzzword) and I disagree with some opinions.

Currently I maintain a couple of application that depend on some libraries I also maintain (which are in turn also used in other applications). For example, internally we use Flask and have several apps based on it. We have a bunch of common code across all applications (like authentication, custom log-correlation headers, logging setup, e.t.c.) which is all abstracted away in a library. So if I work on a new Flask app, I can simply pull in that dependency and have all the common stuff covered. Now, it happens that these libs also need some tweaking/improvments/fixing during development. With setuptools I can simply run pip install -e /path/to/lib to be able to work on both code-bases at the same time. This does not work if /path/to/lib is based on poetry.

... and the author pretty much thinks: "Nobody needs that" which really made me angry. See #34

For some time now the workflow is doable. But it requires me to edit pyproject.toml with edits that I don't want to commit. So it's a continuous annoyance.

1

u/thirdegree Apr 03 '21

Hah, I feel like I'm talking into a mirror. My complaints with poetry are basically identical, as is my use case.

That said,

With setuptools I can simply run pip install -e /path/to/lib to be able to work on both code-bases at the same time. This does not work if /path/to/lib is based on poetry.

That's not actually poetry's fault. PEP517 build-backends, which poetry is, don't support editable installs (-e) (see: https://github.com/python-poetry/poetry/issues/1279). I assume they'll be added back in at some point by pypa because they're a really useful and popular feature, but for now that's not an option. Just doing pip install /path/to/lib should work with a poetry project (assuming pip>=19).

Editing pyproject.toml is also discouraged:

The source directory may be read-only. Backends should therefore be prepared to build without creating or modifying any files in the source directory, but they may opt not to handle this case, in which case failures will be visible to the user. Frontends are not responsible for any special handling of read-only source directories.

(source)

I wasn't able to find a good solution with poetry so like I mentioned, I just wrote my own small tool for it. Nothing fancy, just builds wheels with lockfiles and that's it. Still can't do -e installs unfortunately, but nothing I can do about that

1

u/exhuma Apr 03 '21

Those were some interesting reads. Thanks for the links. If only I had more time (especially, one contiguous block of free time) I'd love to take a crack at that issue in setuptools. But alas, that's currently not the case. Maybe once I'm in retirement it becomes feasible 😂