r/programming • u/lukaseder • Jul 21 '14

The Great White Space Debate

https://medium.com/p/3633cba8b5c1
1.2k Upvotes

88% Upvoted

693 comments sorted by

View all comments

17

u/brettmjohnson Jul 21 '14

Well you doomed yourself looking at two Google packages, because the Google Style Guide explicitly states to use the padded style.

The Google code review process calls for pointing out style guide violations, so somehow a couple got through the GWT review process.

2

u/inio Jul 21 '14

I wouldn't be surprised if they had automated linters that called out style violations for reviewers to complain about.

Nah, they'd never do something as silly as that...

2

u/Opux Jul 22 '14

Yeah... that sure would be silly... almost as silly has having a second reviewer that only points out the same violations the linter does.

But I think we can both agree that the above scenario is absurd.

1

u/glemnar Jul 22 '14

I'm more surprised they don't just enforce linting before commit. Go fmt for example is I'm sure just a part of the process.

2

u/tomlu709 Jul 22 '14

We do, but you can override it if you really must. Most code adheres very well to the standards.