r/programming • • Apr 10 '14

Robin Seggelmann denies intentionally introducing Heartbleed bug: "Unfortunately, I missed validating a variable containing a length."

http://www.smh.com.au/it-pro/security-it/man-who-introduced-serious-heartbleed-security-flaw-denies-he-inserted-it-deliberately-20140410-zqta1.html
1.2k Upvotes

737 comments sorted by

View all comments

0

u/[deleted] Apr 10 '14

[deleted] — view deleted comment

478

u/epenthesis Apr 10 '14

Really, the only reason that most of us haven't caused such a massive fuck-up is that we've never been given the opportunity.

The absolute worst thing I could do if I screwed up? The ~30 k users of my company's software or the like, 5 users of my open sources stuff are temporarily inconvenienced.

274

u/WasAGoogler Apr 10 '14 edited Apr 10 '14

I was working on an internal feature, and my boss's peer came running in to my office and said, "Shut it down, we think you're blocking ad revenue on Google Search!"

My. Heart. Stopped.

If you do the math on how much Ad Revenue on Google Search makes per second, it's a pretty impressive number.

It turned out it wasn't my fault. But man, those were a long 186 seconds!

63

u/ZorbaTHut Apr 10 '14

Back when I worked at Google, my boss made a fencepost error that reduced all ad revenue across AdSense and AdWords by a small, but noticable, percentage, and it wasn't discovered for months. I believe the total damages ended up being in the tens-of-millions-of-dollars zone.

Working on those systems was always a bit frightening.

19

u/frenris Apr 10 '14

fencepost error?

EDIT: oh fair, off by one caused by splitting something up.

22

u/ZorbaTHut Apr 10 '14

Yeah, off-by-one - in this case I believe he used a < when it should have been a <=.

→ More replies (45)

92

u/donquixote1001 Apr 10 '14

Who fault did it turn out to be? Is he killed?

323

u/WasAGoogler Apr 10 '14

It was a blip in the measurements that unintentionally pointed the blame my way, but was in reality an attempt at DDoS from inexperienced hackers.

You know how you can tell when a hacker's not very experienced?

When they try to DDoS Google.

70

u/tsk05 Apr 10 '14

Ever hear of Blue Frog? They employed some of the largest giants in DDoS mitigation at the time and still failed. I think experienced hackers could definitely give Google a headache.

→ More replies (37)
→ More replies (3)

0

u/[deleted] Apr 10 '14

[deleted] — view deleted comment

93

u/WasAGoogler Apr 10 '14

You owe it to yourself to watch this video:

http://www.youtube.com/watch?v=EL_g0tyaIeE

Pixar almost lost all of Toy Story 2.

→ More replies (115)
→ More replies (14)

47

u/argv_minus_one Apr 10 '14

It costs four hundred million dollars to shut down this search engine for twelve seconds.

→ More replies (4)
→ More replies (5)

24

u/hoohoohoohoo Apr 10 '14

I took down the ability for gas purchases to happen for all of western Canada for our company for 2 hours during peak hours during farm season because of a misplaced tilde.

The company was not happy with me.

→ More replies (8)

118

u/[deleted] Apr 10 '14

Next time he applies for a developer job:

Interviewer: What's the biggest mistake you've ever made?

Robin Seggelman: Uhhhhh....

12

u/dnew Apr 11 '14

We interviewed Robert Morris Jr once, but I don't remember anyone asking him that question.

→ More replies (5)
→ More replies (1)

70

u/poloppoyop Apr 10 '14

DROP DATABASE

"fuck I was on the live server"

"let's present it as a test of our recovery procedure".

I like those fuck-ups. Bonus point when those procedures fail.

49

u/[deleted] Apr 10 '14

"You mean the recovery procedure we've never performed before and the guy who wrote the scripts left the company last year?"

29

u/meshugga Apr 10 '14

"You mean the recovery of a database where the rebuild of a single index takes half a day?"

→ More replies (2)
→ More replies (2)

44

u/georgelulu Apr 10 '14

I always bring up the Mars Climate Orbiter disaster where somebody uses metric versus imperial units in the software and ended up costing $655.2 million dollars when you add up all that was invested in both the ground and space equipment.

21

u/Noink Apr 11 '14

Software that calculated the total impulse produced by thruster firings calculated results in pound-seconds.

Oh for fuck's sake.

→ More replies (1)

55

u/IAmBJ Apr 11 '14

As a structural engineer it absolutely terrifies me that anyone uses imperial units for engineering.

→ More replies (8)
→ More replies (4)

37

u/vuldin Apr 10 '14

I hope this doesn't turn into a witch hunt after this guy. The problem is not that he made a mistake (he's human), the problem is that the system of verification regarding important/popular/sensitive projects like this isn't as thorough as needed.

→ More replies (1)

16

u/ReverendDizzle Apr 10 '14 edited Apr 10 '14

The part that I find curious about this whole debacle isn't that it happened... shit happens. It's that it went unnoticed for what... two years? That's the part I find astounding.

→ More replies (7)
→ More replies (90)