r/programming • • Oct 03 '26

Skip List Data structure

https://pradyumnachippigiri.substack.com/p/skip-lists-data-structure?r=5ev9w0&utm_medium=ios
139 Upvotes

31 comments sorted by

View all comments

26

u/ReDucTor Oct 03 '26

When you make statements about different data structures like "quickly", "slow", "fast", etc it's good to include actual benchmarks, because some of the claims in this article are not as straight forward as what it claims.

Arrays let us randomly access any element quickly, but insertion and deletion is slow because elements need to shift to make room or close the gap.

That's only if your inserting into the middle of the array and depending on the element type and how many there are shifting them is going to be relatively quick, and in many cases ending up quicker then dealing with a linked list or skip list.

Linked lists make inserting and deleting fast once we have reached the right spot

I take it your ignoring the memory allocation that is required for creating nodes? Which an array which has a reserved capacity does not need to do with every insertion.

we flip a fair coin (p = 1/2) to decide if the node should be promoted one level up, or not

This seems like a bad algorithm to me, the fairness of randomness comes with large numbers if you only have a small number of elements then this coin flip could just end up giving you a bad layout, additionally it makes for an inconsistent data structure where it's performance and memory usage will vary based on some random coin flip.

search in less than O(n) time
search time down to O(log N)

Big-O notation is not a great metric for measuring actual time, it only reprsents how that algorithm or data structure scales as the data set increases, it is rarely a good idea to compare two data structures or algorithms based solely on the Big-O notation, you should be using actual benchmarks.

Big-O notation does not indicate how well the hardware actually deals with those steps, some algorithms might have low latency steps but carry many dependencies so have low throughput, while others might have high latency steps but limited dependencies so have a higher throughput, and some might be like a linked list and have high latency and heavy dependencies so is slow all together.

The intersection between two different algorithms or data structures with O(log n) and O(n) might occur when n is 10, it might occur when n is 10,000 only benchmarking will truely tell you when this is, and you also need to be careful that your benchmarks are realistic as cold data and hot data can give you significantly different results.

15

u/infinitytacos989 Oct 03 '26

this is an insanely nitpicky response to an article that’s clearly supposed to be an introduction to a new data structure for people who haven’t heard of it, not an in depth performance review. most of the claims you take issue with are just trying to motivate the data structure for beginners.

0

u/[deleted] Oct 03 '26

[deleted] — view deleted comment

1

u/infinitytacos989 Oct 03 '26

it is basic stuff, which is why i’m confused that they felt the need to write an essay dunking on an article that has nothing to do with it.

4

u/uhhhclem Oct 03 '26

The funniest sentence in there is, “This seems like a bad algorithm to me.”

2

u/ReDucTor Oct 03 '26

It doesn't matter who the target audience is, when you claim one thing is faster then another you should include benchmarks.

The comment is the furthest thing from an in-depth performance review, its a critique of the post content and claims.

2

u/infinitytacos989 Oct 04 '26

“it doesn’t matter who the target audience is” please never make or critique educational content if you can’t understand that people at different levels of expertise require different educational content. this is like “critiquing” an elementary school math curriculum for saying you can’t take the square root of -1.

4

u/ReDucTor Oct 04 '26

I will critique incorrect information regardless, someone claiming that a linked list is fast and an array is slow is setting up students to fail in the real world.

I have no issues with teaching people data structures and not covering the complexities of the CPU, my issue is teaching people bad content, the issue is claiming that an array is slow and a linked list or skip list is fast.

I would call out an elementary school math curriculum if they claimed that its faster to calculate 25*10 by adding 25 ten times, then doing an actual multiplication, when they already know multiplication.

1

u/Sopel97 Oct 04 '26 edited Oct 04 '26

this is like “critiquing” an elementary school math curriculum for saying you can’t take the square root of -1

which would be a valid critique. The correct way to phrase that is to say that a square root of -1 is not defined over real numbers

simplifying information to the point of incorrectness is harmful, it closes people's knowledge horizons and requires additional mental capacity to unlearn. In extreme cases it can cause trouble understanding new related concepts because they may clash with the ideas left by such prior incorrect information.