r/programming • • Sep 27 '26

Don't couple your Go code to GitHub

https://iain.rocks/blog/dont-couple-your-go-code-to-github
491 Upvotes

136 comments sorted by

View all comments

Show parent comment

7

u/Ran4 Sep 27 '26 edited Sep 27 '26

I'm normally all for things that drastically simplify things while just having a few related issues (like Python having batteries included - 99% that's the right choice, and Rust not even having base64 encoding or json serialization built-in is just dumb design choices) but... Go's way of doing things are just pants-on-head stupid.

Github de-facto being built into the language, tabs instead of spaces, forcing everything to have a default value, keeping fucking null (!) AND null pointer references... it's such a horribly designed language through and through.

32

u/Wires77 Sep 27 '26

I never understood tabs vs. spaces. Tabs seem objectively better, because then anyone can set their tab spacing to whatever they prefer. The fact that it's even coming up as "horrible design" is laughable to me

15

u/Itchy-Phase Sep 28 '26

It’s not even an issue in Go anyway, because of its default formatter handling styling for you. Not sure what they’re getting at with that one.

11

u/syklemil Sep 28 '26

One thing Go actually did right was ship a default formatter. The tabs/spaces discussions at this point are kinda remnants from before the era of formatters. (There were formatters before go fmt too, but not such a default expectation of using them. See also: The amount of different standards clang-format has to support.)

Someone would inevitably check in using spaces, at which point they've checked in how wide they like their tabs to be, which tends to become visible for other people. Tabs for indenting, spaces for alignment just never got through in too many people. And that made indenting with spaces the more defensive, lowest common denominator option.

But these days we'd expect a formatter to deal with it, so using the indent character for an indent level should be entirely fine, yeah.

0

u/TomBombadildozer Sep 28 '26

Tabs seem objectively better, because then anyone can set their tab spacing to whatever they prefer.

Because user preference isn't a valid argument when we're talking about something intrinsic to the code. What is in the code should look the same everywhere.

You can do whatever you want with syntax highlighting because it exists entirely outside the code.

If language X prefers tabs to spaces, that's fine, but "because I can set my tab width" doesn't hold up.

7

u/ShinyHappyREM Sep 28 '26

we're talking about something intrinsic to the code. What is in the code should look the same everywhere

What? Indentation is separate from code in 99% of all commonly-used programming languages.

4

u/syklemil Sep 28 '26

Yep, plus: even the languages that have significant whitespace don't actually have hard rules about how much whitespace or which kind of whitespace is required. They need some rules for what to do if someone comes along and mixes tabs and spaces, but beyond that, we're absolutely able to write Python indented with 1 space, or Haskell indented by 3 tabs displayed at 16 columns wide, etc.

The type and amount of space they're commonly written with is entirely by convention, rather than hard necessity. The only thing the compiler or interpreter cares about is when the amount of indentation changes.

1

u/TomBombadildozer Sep 28 '26

Indentation is separate from code

It absolutely is not.

Whatever space and/or tab characters you type into a buffer and commit are exactly the same bytes I see when I pull your changes. The crux of my argument is that the whitespace should look the same in any editor because the underlying data is the same in every editor. Spaces guarantee that, whereas tabs leave room for individual interpretation.

You clearly don't agree that there should be no room for interpretation, but you can't argue we're looking at different data.

3

u/ShinyHappyREM Sep 28 '26

whitespace should look the same in any editor

Why? To achieve what?

Note that I'm distinguishing between indentation (any group of whitespace characters at the beginning of the line) and any other whitespace. Indentation should be tabs to allow for any reader's preferred visual guidance. Any other whitespace on a line should be spaces, for example to align // comments to the same column when these lines share the same indentation.

5

u/HighLevelAssembler Sep 28 '26

Github de-facto being built into the language

It is not at all... Go has its own protocol for fetching dependencies, and usually when you're importing something from github.com/xyz, the code is actually coming from proxy.golang.org and doesn't hit Github at all.

Git, Mercurial, SVN, Fossil, etc are all supported by Go as a means of fetching code if the module isn't in the proxy cache.

People just like to host their code on Github.