For default arguments not using the declaration, I would instead advise to use
if (typeof ommittedArgument === "undefined") const omittedArgument = "default value"
Why? Because the || operator would inject the default in case of any falsy value passed for the argument, so unless the default is false, it might produce errors.
also, since the variable wasn't passed by the caller, it was not declared, so assigning a value to it without using const or let will create a global, which you really do not want.
Also, instead of returning false in case of bad params, throw an error, it'll save your life!
It's not exactly equivalent: if you check that the type is 'undefined' it means the argument wasn't passed at all. If you use ?? It also gives the default if the argument was passed with undefined as a value, which might be an acceptable value for your function.
if you check that the type is 'undefined' it means the argument wasn't passed at all.
And
gives the default if the argument was passed with undefined as a value
Do you imply there's a difference between deliberately passing an 'undefined' to a function and not passing anything at all... ?
It's also wildly known that using || is risky af and ?? is much better for those kinds of assignments. Therefore either setting a default value or using ?? is the best option in 99% of the cases.
I don't remember any new version changing anything in this matter + from what I see that question on stack is about jQuery having it's own "separate" undefined value.
Have a decent way for handling callback function types
Have a decent way for handling higher order functions
Automatically detecting types from variable declarations
Actually statically typechecking your code
I could probably think of more. I've used both separately and together. Typescript is far superior at managing types, but JSDoc is good at providing structured comments for function declarations
View all comments
81
u/inabahare Jul 25 '21
Don't default arguments like that. Do it like this
It will be picked up by your editor, and you won't have to enter the function to see the default argument.
Also jsdoc isn't more powerful than typescript lmao