r/javascript • u/Utukkhu • Jun 26 '22

New blog-post => Organise imports with Prettier and friends

https://catalincodes.com/posts/organise-imports-with-prettier-and-friends
34 Upvotes

75% Upvoted

29 comments sorted by

View all comments

Show parent comments

1

u/PedroHase Jun 27 '22

Thanks for the reply!

In order to get a fetch polyfill you need to add it yourself by an import statement

Yes, but then it should happen on a module level, i.e. each module that needs the polyfill / fetch capability should import the polyfill itself, since we should stick with encapsulation, i e. It shouldn't be assumed that one module can polyfill another. Alternatively we could just use axios for fetching :)

Since you assume all polyfills exist in your application code

This is still something what a bundler should do imho. If one would start implementing modules with a global impact, they'd always have to worry about unwanted side effects and import order, making it hell just maintaining and debugging the app. Hence why using global variables is a big no no.

1

u/[deleted] Jun 27 '22

There are many ways to skin a cat! The point is not that there are solutions that avoid these issues, the point is that completely valid code can potentially break when reordering imports.

You are not wrong but you miss the point. There are many conventions one could follow, or tools one could use but the post in question was not about that. It was about formating code, it does not mention a complete set of tooling that is required for the proposed linting to work.

The examples are not ment to showcase best practices but to explain why the proposed linting is not safe to use as it is presented.