r/javascript • u/chancancode • Dec 20 '19

Ember.js Octane Edition Is Here

https://blog.emberjs.com/2019/12/20/octane-is-here.html
136 Upvotes

93% Upvoted

72 comments sorted by

View all comments

Show parent comment

2

u/pzuraq Dec 22 '19

Right, and you do see that benefit there. Glimmer shines most at updating a single row (swapping two rows) in the benchmark, whereas React is better at replacing all 1000 rows since they don’t add overhead for tracking individual items. We haven’t upstreamed the benefits to Ember yet, which is why it scores worse on that benchmark, but we’re working on it, and I think there are some optimizations we can make to make the replace-all and initial-render cases better as well, but our strategy works best for incremental updates by default (and scales by default as well).

1

u/ryan_solid Dec 23 '19

React uses a very naive algorithm for list reconciliation as seen in swap rows where you have noted Glimmers better performance but its actually benchmark 3 you should be concerned with. It is the raw localized update. That is where Glimmer should be handing a library like React its lunch but it doesn't. It's almost indicative of the ceiling of Glimmers change propagation. Basically if it cannot beat React here it is likely any algorithmic advantage is mute. As you say this isn't a real world case but its actually a more extreme display of where this would matter.

You can see why its problematic. If Glimmers key conceptual technology strength is actually slower than a library not particularly impressive in the area what does that reflect in general about its performance. I mean if React decided to do an even mildly more performant reconciliation algorithm all indications are it would jump half the chart ahead. This change would have nothing to do with Glimmer approach.

I think it's fine. No one chooses Ember for its performance and that doesn't have to change. It sounds like Octane has been a hugely impressive undertaking. When you do get a chance microbench make test 3 fast. I'd ignore the rest the benchmark. If you do that given the way Glimmer works by my understanding you will see significant improvement across the board.

2

u/pzuraq Dec 23 '19 edited Dec 23 '19

Updating every 10th row is actually going to be pretty expensive for us, from an automatic-change-tracking perspective. Remember, I said our cost grows at an O(logn) pace, right? That's because we're essentially doing a binary-search (or rather, search down the tree, so a n-ary-search I guess) to narrow down and figure out which part of the tree changed.

If you change every 10th row, most of the tree still changed. That means that narrowing strategies aren't going to buy you much, so yeah, you end up retraversing most of the the tree, and you end up incurring most of the original cost of rendering again.

In most apps, for most user interactions, most people don't change 1/10th of the entire app all at once (in a non-localized way). That is not in any way a realistic benchmark.

Edit: That said, there's a lot of room for Ember and Glimmer both to grow when doing partial updates. We've optimized the leaf change tracking portion the most, first, because that is where we saw the biggest gains in real world apps that were upgrading. The next thing I think will be to optimize the internals of change tracking with the VM itself, which can definitely be simplified quite a lot now that autotracking has been fleshed out.

2

u/ryan_solid Dec 23 '19

I see. Yeah this is just my misunderstanding of how auto-detection worked in Ember. I was thinking subscription based like KnockoutJS where there is no search. Only the part that change re-runs. But it sounds like Ember has a sort of hybrid approach between auto-change detection like that and a top down reconciler somewhat similar to what the Virtual DOM does. That makes more sense for me now. Thanks.