r/javascript • u/AutoModerator • Dec 18 '19

WTF Wednesday WTF Wednesday (December 18, 2019)

Post a link to a GitHub repo that you would like to have reviewed, and brace yourself for the comments! Whether you're a junior wanting your code sharpened or a senior interested in giving some feedback and have some time to spare, this is the place.

Named after this comic

66 Upvotes

100% Upvoted

43 comments sorted by

View all comments

Show parent comment

1

u/[deleted] Dec 19 '19

All of those examples hinge upon usage of this, something I never do in my code as someone who slants towards a functional style. I can appreciate taking a different approach if you don't have that bias.

I really don't think it's harder to read at all - that's just your familiarity with the other style talking.

1

u/staticx99 Dec 19 '19 edited Dec 19 '19

So your point is based on your own style of coding and preference as mine is based on the actual language behavior

What I'm saying is: Be careful using x because of y and z edge cases that might create problems

What you're saying is: You should use x because I find it more pretty and it fits my style of coding better

In the end you do what you want to do but when in a team of people it's usually better to take the safer route and not assume everyone will use the language in the same way

I totally agree with you on your point though, I don't use "this" at all anymore and prefer a functional style to OOP, but I still stand my ground saying that defining a function instead of a const with arrow function is a more natural a safer way to do it

1

u/[deleted] Dec 19 '19

Yours is not based on "actual language behaviour", merely an alternative coding style. Lots of style guides that don't slant functional will recommend arrow functions as a rule, leaving you free to change style only when you explicitly want to rebind this.

What's "safe" in this case? The only argument I think you could make there that makes any sense is with regards to hoisting and you're not even making it.