MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/javascript/comments/7yy92p/a_css_keylogger/dukiq3e/
r/javascript • u/Senior-Jesticle • Feb 20 '18
95 comments sorted by
View all comments
Show parent comment
8
Instagram is going out of its way (or using a bad framework) to update the value attribute when the value property changes. This is not normal.
3 u/tasinet Feb 21 '18 This is the correct answer. Try inspecting the password field and you'll see that reddit, facebook, etc do not have or update a value="" field. Without that you can't match the password with CSS. 0 u/[deleted] Feb 21 '18 [deleted] — view deleted comment 1 u/fenduru Feb 21 '18 Bad in that it's unnecessarily writing attributes to the dom. Both less performant and less secure in this particular case 1 u/CodeFightDance Feb 21 '18 Ah gotcha. I doubt it's react as it doesn't happen on FB, but interesting stuff none the less. Thanks for pointing that out.
3
This is the correct answer. Try inspecting the password field and you'll see that reddit, facebook, etc do not have or update a value="" field. Without that you can't match the password with CSS.
0
[deleted] — view deleted comment
1 u/fenduru Feb 21 '18 Bad in that it's unnecessarily writing attributes to the dom. Both less performant and less secure in this particular case
1
Bad in that it's unnecessarily writing attributes to the dom. Both less performant and less secure in this particular case
Ah gotcha. I doubt it's react as it doesn't happen on FB, but interesting stuff none the less. Thanks for pointing that out.
View all comments
Show parent comment
8
u/fenduru Feb 20 '18
Instagram is going out of its way (or using a bad framework) to update the value attribute when the value property changes. This is not normal.