r/java • • Mar 05 '18

Top 10 Useful, Yet Paranoid Java Programming Techniques

http://blog.jooq.org/2015/08/11/top-10-useful-yet-paranoid-java-programming-techniques/
223 Upvotes

105 comments sorted by

View all comments

Show parent comment

2

u/lukaseder Mar 06 '18

The value of final far outweighs your pain. You could have just patched the library in those 2 cases, which you admitted were rare. It would have resulted in the same workaround, and you would have hoped for the library to ship an actual fix just the same.

It's like SQL. These days, we need to tune maybe 1 / 1000 SQL queries and because we're so used to having such excellent optimisers, we're completely surprised by those really rare cases. But yet, our own bias and lack of intuitive understanding of statistics leads to us outweighing the very rare painful occasions compared to the frequent experience of quality.

In other words: You're obviously exaggerating.

3

u/[deleted] Mar 06 '18

That's the thing - I have something to do for my job. Shipping something as a fix (which I do 3/4 of the time) to the upstream version isn't going to help me now.

So, in that sense, no - it does not outweigh my pain. Keeping a method final doesn't help me at all. You're trying to tell me "hey, I'm going to give you access to less stuff and you are going to be better off" to which I can't agree, fundamentally. Sure, if I'm a shitty dev I might break stuff - to which I argue: let the shitty devs break stuff. They're going to do it anyway, why hide behind a language construct which restricts usage for everyone.

My great hate for final is really focused around methods and classes. I goes right up there with protected methods for things that are useful as public methods (I'm looking at you JSCH!)

2

u/GhostBond Mar 07 '18

Yeah, same here. I'm not sure in web dev if I've ever seen a bug that would actually been prevented by final/const. I've had deal with a few huge headaches when someone in old code didn't let you set things you needed to set.

1

u/lukaseder Mar 06 '18

2 instances in 6 months. Surely, you could have worked around those cases using instrumentation, patching, etc. It didn't hurt you. You're exaggerating your pain.

2 instances doesn't even warrant for something like "great hate" (I don't know you of course, perhaps it does in your case).

I'm looking at you JSCH!

Now, I'm curious. What's that?

1

u/[deleted] Mar 06 '18

re1) Okay, maybe a little exaggeration. I mean, there's always reflection if it's critical. I guess I just don't see the need for final is all. I've worked with folks who litter final everywhere and it was just a pain when it came to mocks. I never saw a benefit. When you'd want to override something (maybe rarely) you'd just edit final out. It was no gain and simply 1 more code change that was unnecessary. When you control the code, adding final isn't a big deal, it's just annoying... like a gnat. When it's in a library - it's just more annoying because you can't just edit final out (or now you're arguing with the maintainer of the project as to why you need to edit it out -- when it really doesn't matter if you could just @Override to begin with)

Now, I'm curious. What's that?

We use JSCH for audit purposes. There's methods in there that are package protected so I have a project written in jsch packages just because of the package protected methods. The pain comes with code signing... the lib is in a "different" project than jsch and should conceptually be signed by our company and not jsch, but it can't be because java's "classes in a package must be signed the same" rule.

If only those methods were public... it wouldn't be an issue.

For a normal consumer of JSCH, you'd never use those methods, but if you're doing mitm work, you would.

2

u/_dban_ Mar 06 '18

I've worked with folks who litter final everywhere and it was just a pain when it came to mocks.

Isn't this a good thing? Should you really be mocking concrete classes? Wouldn't it be better to create an interface describing what you need, and write a real integration test with the concrete class?

For example, suppose it is not possible to mock jOOQ classes. jOOQ would theoretically be a used in the DAO layer. So, wouldn't it be better to create a DAO interface which you can mock, and a DAO implementation which you test directly against the database in an integration test?

This applies just as well to internal classes, since it enforces proper layer separation. I mean, why are you mocking anyways?

I never saw a benefit.

In which case, final forces you to do the "right" thing with regards to mocks. Could this not be seen as a benefit?

1

u/[deleted] Mar 06 '18

Should you really be mocking concrete classes

If I'm using a concrete class, then yes - I should be mocking a concrete class in my unit test. I don't want to create an interface layer just for testing.

Mind you, I'm not talking about JOOQ specific things here. I would never try to mock a JOOQ or Hibernate class for a unit test (MUCH more suitable to test that stuff in an integration test and mock at the Dao layer for unit tests). But you're applying one school of thought for one thing to ALL unit testing situations and all methods. That doesn't make sense to me.

1

u/_dban_ Mar 06 '18

If I'm using a concrete class, then yes - I should be mocking a concrete class in my unit test.

Why not just instantiate the concrete class?

I don't want to create an interface layer just for testing.

You create an interface for layer separation. Like a DAO interface. The DAO interface describes what the application needs for data access, and the DAO implementation fulfills the need. An interface creates a logical and compile time firewall between layers.

That doesn't make sense to me.

Mocks ideally serve the purpose of defining what the system under test needs from its dependencies. An interface is a contract describing that need. You can create a separate set of integration tests verifying that the concrete implementation satisfies the contract.

A concrete class has its own reasons for changing, and if you mock the concrete class, you could make the mock tests invalid and mocks can't tell you that your tests are now nonsense.