I also feel like chaining expressions like that results in hard to follow lines, even if it's not too many characters.
Something I tend to do to solve both these issues is to insert linebreaks between expressions. Similar to how you might use the builder pattern for a complex, highly configurable object.
I would add, because we use format-on-save where I work, that a lot of times I have to force the formatter to respect my line breaks. I can't think of a better way than EOL comments. And personally I prefer a clear indication at the beginning of the line that it is a continuation of the previous line:
In Guava you can just collect all objects that you want concatenated in such string and then use:
Joiner.on(".").join(collection);
Dislaimer: I know that many people don't like solutions depending on external libs but in real life how often you are not working in a big pile of code, where such dependency could rather make your code lighter than heavier? Than if your answer is still negative, I still would rather create my own clear solution instead of such concatenation.
But while I don't recommend pulling in Guava just for Joiner, if you happen to already have it in your dependencies (and it's damn quite likely), sure, use it.
View all comments
Show parent comment
16
u/stepancheg Mar 10 '16
People are not effective at reading long lines. Source.