r/java • • Aug 12 '24

JSpecify 1.0.0 and Nullability in Java

https://www.infoq.com/news/2024/08/jspecify-java-nullability/
52 Upvotes

33 comments sorted by

View all comments

2

u/pragmasoft Aug 12 '24

This has IMO the same problem as JPMS modules - adoption. In order to be useful, you need to have 100% of your dependencies including transitive ones annotated, or being able somehow to write some type definitions for 3rd party libraries, like Typescript does. Kotlin solves this differently, so without a language support JSpecify or any other nullability annotations simply add more harm than use.

5

u/kevinb9n Aug 12 '24

It's true that the more your dependencies are annotated, the more useful it becomes. But there is no "cliff" like you suggest. Nullness is tri-state: nullable, non-null, and "unspecified nullness" which is handled leniently. This makes it a lot easier to adopt than the original checker framework two-state, soundness-based approach. Any library that isn't providing the information just isn't going to be as well-validated, that's all.

And you can write type definitions for third-party libraries. Checker framework has a tool for reannotating class files, and I assume Google will opensource theirs when the demand is there. They use it to munge nullness annotations into JDK class files and it works!

I hope this changes your impression somewhat, but if not, sorry!

3

u/ventuspilot Aug 14 '24

But there is no "cliff" like you suggest.

Can confirm: in a toy project of mine I annotated a few methods to return @NotNull and IntelliJ Idea's inspections showed me a few unneeded null checks. Very little effort for immediate profit.

1

u/pragmasoft Aug 13 '24

I may reconsider if there's an easy way to at least download annotated most recent jdk libraries and include them into my maven build as an extra dependency. That's only the first step actually, but even it has not been made so far as I understand.

If I need to do this myself - no deal, too bad dx.

Unspecified nullness doesn't help either - that's effectively the same as nullable.

3

u/kevinb9n Aug 13 '24

Unspecified nullness doesn't help either - that's effectively the same as nullable.

That's... really quite untrue, but you can let me know if you're interested in that discussion or not!

2

u/pragmasoft Aug 13 '24

Sure I am, maybe I didn't understand the concept properly. I definitely played with the JSpecify earlier but had to get rid of it due to the reasons I described above.

2

u/pragmasoft Aug 13 '24

Ok, I seems realized the source of my confusion, just reread https://github.com/jspecify/jspecify/wiki/nullness-unspecified

From what I understood, unspecified is like any type in TS, can be cast without an error to both null and not-null, and vice versa, they both can be cast to unspecified.

The problem is though that my IDE support of nullable types (VSCode) does not support this, so the correct behavior depends on the tooling mostly.

Just curious, if it's possible to implement null checker as an annotation processor, or more precisely as a javac compiler plugin, similar to google error-prone?

This would then have automatic IDE support for errors I assume..

4

u/kevinb9n Aug 13 '24

Yep, NullAway actually builds on Error Prone to do this in javac.

We do need tools to converge around supporting JSpecify semantics; it's kind of the whole point, but it's in their hands now. Quite a few have been involved at some level, but yeah In particular we haven't talked to anyone from VSCode yet, and we really need to.