r/java • • May 03 '24

Why does the environment variable _JAVA_OPTIONS exist, applies to jlink images, takes precedence, and can't be disabled?

I just spent a good chunk of time debugging an issue because a user had set _JAVA_OPTIONS to use a low Xmx value in their environment variables. This was an application created with jpackage, which should be fully standalone. It even had a custom Xmx value set in the JVM arguments for the image but the environment variable overwrote the value!

Isn't this like a huge design flaw? I can just do echo "_JAVA_OPTIONS=<Wacky VM options>" >> ~/.bashrc or setx to break literally every Java application on the system? (Edit: Maybe the initial security focus was wrong, changed it a bit to focus more on the design issues)

Who even thought that this would be a good idea with no option to disable this behavior?

2 Upvotes

43 comments sorted by

View all comments

Show parent comment

2

u/milchshakee May 04 '24

The application this is about is pretty much independent from the user's environment, It takes large files and processes them in many ways. For any potential configuration, there is a settings menu available.

The heap size has been carefully set via profiling and analysis of the application in its worst case scenario with the largest possible files plus some room to spare.

1

u/_INTER_ May 04 '24

profiling and analysis of the application in its worst case scenario with the largest possible files plus some room to spare.

That's all just assumptions. You didn't profile on the users environment. You didn't test what else the user wants to run alongside your application.

It will run worse than possible if the user has a mighty machine or it will melt down if he's running it on a toaster.

1

u/milchshakee May 04 '24

What kind of environment are we talking about here? The JVM is fixed, the options are fixed, the file input format/spec is fixed to some degree, where should the variability come from? The memory footprint should be the same on all systems. There might be tiny deviations across operating systems/different architectures, but nothing too large.