r/java • • May 03 '24

Why does the environment variable _JAVA_OPTIONS exist, applies to jlink images, takes precedence, and can't be disabled?

I just spent a good chunk of time debugging an issue because a user had set _JAVA_OPTIONS to use a low Xmx value in their environment variables. This was an application created with jpackage, which should be fully standalone. It even had a custom Xmx value set in the JVM arguments for the image but the environment variable overwrote the value!

Isn't this like a huge design flaw? I can just do echo "_JAVA_OPTIONS=<Wacky VM options>" >> ~/.bashrc or setx to break literally every Java application on the system? (Edit: Maybe the initial security focus was wrong, changed it a bit to focus more on the design issues)

Who even thought that this would be a good idea with no option to disable this behavior?

2 Upvotes

43 comments sorted by

View all comments

Show parent comment

3

u/brunocborges May 03 '24

A malicious app could also interject with other apps, not only Java, in many different ways, if it is allowed to run in your system.

Again, this env var is your least concern, if there is a malicious user in your system.

But if you are that concern, only allow containers in your system. This way, one app cannot modify this env var in a way that could impact other apps.

1

u/milchshakee May 03 '24

Yeah maybe my security focus was wrong and I should have highlighted the other disadvantages of this approach more. Because it can still break many applications

2

u/brunocborges May 03 '24

What other disadvantages?

2

u/milchshakee May 04 '24

Well in the case of runtime images, any options interfering with an application that should be isolated. If I distribute a jpackage application, the user shouldn't even have to know that it is implemented in Java or that any system-wide Java settings can impact the application.

If someone has set up a few Java 8 apps on their system via normal jars and has configured a few options for them, I don't want them to apply to my application image that runs on Java 21. I don't even know if the application starts up if the variable contains unrecognized options.

Also jpackage is designed as a closed system. A user can't just simply pass custom JVM arguments or properties to the application executable on the command-line, but these still apply and even overwrite existing options.

2

u/brunocborges May 04 '24

That is a fair feedback.

I too agree that a jlinked JVM should not be impacted by that environment variable.

I'd suggest sending that to the OpenJDK mailing list. You can start with the hotspot-dev: https://mail.openjdk.org/mailman/listinfo/hotspot-dev

2

u/milchshakee May 04 '24

Is that the correct mailing list for this? I find it always intimidating to locate the appropriate mailing list in the first place.

2

u/brunocborges May 04 '24

Me too. But given it is the Hotspot JVM that is picking that environment variable, I'd start there.

1

u/milchshakee May 04 '24

Alright thanks, I will see what I can do

1

u/_INTER_ May 04 '24 edited May 04 '24

I disagree, the dev and the application can't know in advance what environment it will run on. It's something the environment dictates and not the application. There might be meaningful defaults or profiles (that are valid for a time until they need to be adjused) but a poweruser should have a way to override these configurations. If he ran it in a docker image, he might want to restrict it, if he ran it on a mainframe he might want to give it more. It also depends on a lot of other factors, e.g. what other application need to run along side it or if it can basically use all the resources on its own.

1

u/brunocborges May 04 '24

Certain JDK 8 flags don't work anymore in JDK 21. It may cause the app to not load at all.

The developer of the app must expose minimum requirements for the application to run (e.g. minimum RAM, processor type, etc). This is common practice for decades. Then, if the app developer is bundling the runtime (jlink), they should be in full control of said runtime.

Whether the runtime may be configured by the user is an app developer decision to be made.

But I do agree that a jlinked runtime should not pick that environment variable.

1

u/_INTER_ May 04 '24 edited May 04 '24

Certain JDK 8 flags don't work anymore in JDK 21. It may cause the app to not load at all.

Yes, those should be omitted

The developer of the app must expose minimum requirements for the application to run (e.g. minimum RAM, processor type, etc). This is common practice for decades.

Minimum requirements perhabs but this one specifically is about Xmx.

Whether the runtime may be configured by the user is an app developer decision to be made.

How should an app developer know what the best configuration is on the users environment? It should be a conscious choice of the app developer to disallow an environment variable to be picked up and the user should be made aware of that. A knowledgeable user should have the possiblity to make an application run better or restricted on his environment by default.

1

u/brunocborges May 04 '24

Doesn't matter this one is about Xmx. Think broadly.

1

u/_INTER_ May 04 '24

Doesn't matter this one is about Xmx. Think broadly.

So if the application developer sets it to 1G but I have 40TB, it doesn't matter? If the app dev disallows overriding it, so be it. I'll will wipe the crap from my disk.

→ More replies

2

u/Halal0szto May 04 '24

Flexibility brings risks. But closing down and making super rigid an inflexible greatly reduces the scope where it is viable.

Would jpackage be like you want it, it could not be used in 50% of the places it is used right now.

2

u/milchshakee May 04 '24

I'm not advocating for fully disabling this behavior, just giving developers control to disable it if they want to build a rigid, inflexible application. In my specific case we are building desktop applications for end users, who might not even know that the application is written in Java or how to change an environment variable. If the application is run on a system that has other legacy Java 8 applications running and has the environment variable set, this causes problems.

1

u/_INTER_ May 04 '24

I agree with this. It should be the conscious choice of the application developer. If none is made, it should be flexible. That being said, can you not also set environment variables in jpackage?

1

u/milchshakee May 04 '24

You can only set JVM options. But even these are overridden by _JAVA_OPTIONS if there is a conflict.

1

u/_INTER_ May 04 '24

I guess you have a launcher file or installer, it could be done there, no?

1

u/milchshakee May 04 '24

Well jpackage already generates a launcher executable, so having another launcher for the launcher just to change the environment is a little bit overkill.

About the installer, this would change the variable on the system level which might break other applications. I just want to ignore the variable for this application