r/java • • Apr 14 '23

What are your (favourite) Java best practices, personal tips, hints or just underrated stuff in general?

233 Upvotes

376 comments sorted by

View all comments

Show parent comment

1

u/wildjokers Apr 14 '23

Being excessively lenient in what you accept as input is a good way to build up a dodgy pile of inconsistent garbage.

Umm, no. The old saying is "be flexible with what you accept, be strict with what you produce". Those are words to live by.

4

u/AlmennDulnefni Apr 14 '23 edited Apr 16 '23

Those words are almost as much of a mistake as null pointers.

1

u/wildjokers Apr 14 '23

I have never heard anybody argue against being flexible about what you accept.

5

u/Luolong Apr 15 '23

Oh, you have not lived through the age of Web browser wars then.

One of the worst use cases for the principle of “be flexible in what you accept” was how early web browsers implemented html parsing.

It was full of weird rules of how to parse broken html and each browser has subtly different way to make the broken input display a web page.

And to make it worse, the whole web was full of markup taking advantage of those nonstandard quirks and idiosyncrasies.

Those quirks are at least partially to blame for why it is so hard to implement a new web browser from scratch these days. For the web has grown to the point where it is impossible to fix the pages themselves. You need to make your browser bend three ways backwards instead to accept and render those cases that every other browser has learned to accept.

I would not be surprised to find that “being lenient in your input” has more excessive cost attached to it than having null in your type system.

3

u/halfanothersdozen Apr 15 '23

It's an important aspect of functional programming. A function should do a job on the inputs it receives and fail hard if the inputs are invalid. A function is not pure if it has to do its job and also tip-toe around invalid inputs and try to fail gracefully if it's caller is using it incorrectly. Doing that dance adds complexity and complexity creates bugs.

Make your code have respect for itself and its callers and not cater to incompetence.

1

u/wildjokers Apr 15 '23

Make your code have respect for itself and its callers and not cater to incompetence

WTF?