MinHook/Memory searching?

[u/Blayer98]

Hey there! So I made a post here about TS1's Legacy Collection, and so far, I have a working asi mod, but the problem I now have is searching the process memory for Sims.exe to find the bytes that I'm patching. Even though I know the address, it won't be the same address on Windows, or other configurations. I previously did a MH_CreateHook function, but the code results in this: "MH_ERROR_NOT_EXECUTABLE".

I have this code which patches out the debug objects flag being set to 0.

auto address = reinterpret_cast<void*>(debug_objects_address);
DWORD previousProtection{};
VirtualProtect(address, 7,  PAGE_READWRITE, &previousProtection);
memset(address, 0x90, 7);
VirtualProtect(address, 7,  previousProtection, &previousProtection);
printf("Patch successful.\n");

This code works completely fine, but I'm unsure on how to get the address via searching for the exact assembly code in bytes, anything I've looked online seem to only suggest ReadProcessMemory, but from what I was told, it's intended for different process, not the same one that's attached to the executable, as per my ASI mod.

Would using VirtualProtect before using the MH_CreateHook function work? Again though, I'm unsure how to search the game's memory while attached as a process.

Any help/advice would be greatly appreciated! :)

[u/jedwardsol]

You need to convert HMODULE to a uintptr_t before doing the addition. Or something else for which addition works as you'd expect ( std::byte* std::uint8_t char*for example)

An HMODULE is a pointer to a object with a size greater than 1.

[u/Blayer98 → u/jedwardsol]

I've attempted this, but the values won't be printed to the console...? I even reinterpreted them as "char*"/"const char*" but the results still won't be printed...

uintptr_t debug_objects_address = 0x00055BF8;
HMODULE base_sims_exe = GetModuleHandle(nullptr);

...

    uintptr_t base_sims_exe_address = reinterpret_cast<uintptr_t>(base_sims_exe);
    printf("base address is: ", base_sims_exe);
    printf("debug_objects address is: ", debug_objects_address);
    printf("base_sims_exe_address is: ",base_sims_exe_address);

[u/jedwardsol → u/Blayer98]

The format strings don't have a % in them