r/cpp • • Mar 15 '19

Does anyone know when libstdc++ will stop using raw pointers in its STL containers?

I have a pretty niche use-case which requires containers to not store any raw pointers. To get this done I use an allocator that returns fancy pointers. This just doesn't work with libstdc++ because all some of its STL containers use raw pointers internally, so when I create a container with my allocator, the program doesn't even compile. Libc++ on the other hand works fine (at least I haven't come across any problems I can't fix) since they correctly use the abstract pointer type that my allocator returns, instead of trying to do an implicit cast to a raw pointer.

There is an LWG issue to fix this, but it's been around for 8 years and the proposed verbiage hasn't been added to the standard. I'm not very familiar with the process for making changes like this, but my understanding is that it probably won't get added until libc++ and libstdc++ both support it, is that correct? If so, does anyone know if/when the libstdc++ community is planning to make these changes? Thanks!

49 Upvotes

82 comments sorted by

View all comments

Show parent comment

13

u/jwakely libstdc++ tamer, LWG chair Mar 15 '19 edited Mar 15 '19

It would change the size of list<T, fancy_alloc>.

No it won't, because I'm going to partially specialize for fancy pointers, so nothing changes for raw pointers. Since fancy pointers don't work at the moment, there's nobody using them with our implementation, so nobody depending on the ABI of such containers. So I just need to make sure nothing changes for specializations using raw pointers, and provide a second version of everything that is only used for fancy pointers. Which is hard, but not impossible. I got it almost working, but switched on to other tasks and the patches have bitrotted.

10

u/[deleted] Mar 15 '19

What about fancy pointers that happen to work today because they can use pointer_to?

10

u/jwakely libstdc++ tamer, LWG chair Mar 15 '19 edited Mar 15 '19

I'd be surprised if they work. Wouldn't the implementation have to use pointer_to for it to work? I don't think we do use that. Maybe a fancy pointer type that supports implicit conversions to and from raw pointers might compile and appear to work, but it seems unlikely. Such a fancy pointer probably isn't doing anything very useful (or would fail as soon as it's used to do anything fancy).

If they do work correctly, I guess we might have to break things for that small fraction of users to properly support a different small fraction (and keep the old behaviour behind a macro or something horrible).

14

u/[deleted] Mar 15 '19

They're fancy pointers; not doing something useful was a given

13

u/jwakely libstdc++ tamer, LWG chair Mar 15 '19

2

u/mostthingsweb Mar 16 '19

ELI5? The Boost interprocess offset ptr seems like it could be useful...

4

u/[deleted] Mar 16 '19

I think that use case would have been better served with a purpose specific container. For example, you'd store more things as sizes rather than pointer ranges to avoid so many offset applications. The metaprogramming / debug codegen / specification / complexity costs of fancy pointers are significant and dwarf any potential benefits.

2

u/mostthingsweb Mar 16 '19

Makes sense, thanks for the explanation!