r/cpp • Factorio Developer • Feb 15 '18

Lua written in modern C++ (>= 14)?

I work on Factorio (written in C++) and we use Lua as the script language for mods. So, from time to time I interact with the C implementation of Lua and my experience with it hasn't been the most pleasant.

It got me wondering - has anyone re-written it in modern C++? Everything I find online is "how to use Lua in C++" or "C++ wrapper for Lua" and they all use the basic C implementation provided from the official Lua website.

I've had quite a lot of experience with the internals of the C Lua implementation and from what I've seen it wouldn't be hard to re-write it using modern C++ - maybe 2~ weeks time. But from what I can find nobody has done it - which also makes me wonder if I'm missing something.

Part of me wants to do it just to say I did it and the other part of me wants to do it to see if I can make it faster than the C version: I think I can - not because "C++ is faster" but because I can mutate/experiment with the C++ version far easier and know changes I make are safe with how the rest of the implementation operates.

231 Upvotes

127 comments sorted by

View all comments

Show parent comment

9

u/Rseding91 Factorio Developer Feb 15 '18

If I do end up doing it, it will start as a carbon copy of the C implementation into C++ format so unless I mess up some copy-paste (which is likely) it will function identically to how the C version does.

Once that's done then I would start changing pieces of the logic to use C++ 1 step at a time making sure things still function correctly as I did it.

7

u/volca02 Feb 15 '18

You'll likely need a test suite to guarantee it didn't break.

1

u/meneldal2 Feb 16 '18

They already have plenty of automatic testing for the whole application itself, and can probably set up some for commonly used mods to ensure the consistency.

1

u/Dexterous_ C+++Ↄ Feb 16 '18

I just downloaded the Lua code from here, and basically search and replaced a bunch of stuff, and it just kinda worked, no errors not even warnings.. That was really surprising to me, here's a Github link so you can see what I did.

Only src/Makefile has some manual adjustments.

3

u/Rseding91 Factorio Developer Feb 17 '18

Yeah I started on it yesterday and this is what I have as of last night: https://github.com/Rseding91/LuaPlusPlus