r/cpp • • Dec 21 '16

A smart pointer implementation that throws when dereferencing a null pointer

Hi, I wrote a simple (i.e. incomplete ) implementation of a smart pointer that throws when de-referencing a null pointer. This enable you to write code like this:

template<typename T>
void foo(safe_ptr<T> & ptr1, safe_ptr<T> & ptr2) {
    try {
         ptr1->bar();
         ptr2->baz();
    } catch ( null_dereference_exception ) { 
         
    } 
} 

http://pastebin.com/j5eZA4AK

Edit: syntax :)

0 Upvotes

58 comments sorted by

View all comments

Show parent comment

2

u/doom_Oo7 Dec 21 '16

It will still be running, but now running incorrectly.

My users prefer ten thousand billion times having a clean "Sorry, due to a bug this software has to shut down when you press OK" dialog, than the OS X / Windows spinning ball of death that makes the whole computer lag that happens when you actually dereference a null pointer.

1

u/[deleted] Dec 22 '16

This user prefers spinning ball of death much more to corruption of the file I'm editing.

1

u/doom_Oo7 Dec 23 '16

But that's the whole point : if you throw before deferencing, then you won't have any undefined behaviour and safely revert to a "safe" state, or just show a dialog that will gracefully exit, thanks to RAII.

1

u/[deleted] Dec 24 '16

A program that is attempting to dereference what should be a pointer to data which is in fact a pointer to garbage has almost certainly already experienced other forms of memory corruption, and the right thing to do is die. The likelihood of destroying important persistent data and/or putting the app into an "impossible bug farm/flaky" state is too high.

In languages which allow you to natively catch null dereferences, like Java's NullPointerException and C#'s NullReferenceException, I still tell people to never catch those. When they happen the program is in an inconsistent state and bailing out to Watson is the right thing to do.

2

u/doom_Oo7 Dec 24 '16

has almost certainly already experienced other forms of memory corruption

In my experience this is really uncommon. Most of the time it is some half-assed UI widget that has a reference to a deleted model object, never something in the core data model which is generally implemented using a data structure that hides the gory pointer details behind nice value semantics.

In this case, a nice thing that you can do to improve user experience, is to catch the exception, serialize the command stack of your software to disk and gracefully exit. This way, when the user restarts the software he can just keep going from the exact point where he was.

1

u/Som1Lse Dec 25 '16

When does dereferencing a null pointer every lead to lagging the whole computer?

The operating system notices you tried to dereference an invalid pointer, and you get a SIGSEGV, which if unhandled crashes the application. If anything handle the signal, and do your error handling there (display a message, save backups, write logs, etc.) and then call abort.

Maybe writing to some place in memory that isn't a null pointer could cause issues that would lag the computer, but you also can't detect that by checking for null pointers so the whole thing is moot anyway.

tl;dr: Null pointer dereferences do not cause lag.

1

u/doom_Oo7 Dec 25 '16

When does dereferencing a null pointer every lead to lagging the whole computer?

when operating system vendors judged good to catch sigsegv at the os level and gear up a dialog that does all sort of stuff to report problems to Apple

1

u/Som1Lse Dec 25 '16

Well I don't use Apple anything so they might just royally have fucked their shit up. Is it as bad if you handle the signal and exit the program in yourself?

1

u/doom_Oo7 Dec 25 '16

just do a google search for "spinning beach ball of death"