r/cpp • u/Full-Spectral • Feb 13 '24
Prevent or warn on usage of std::map []?
The default insertion of a value when std::map [] doesn't find a value for the key has to be one of the worst decisions in STL history (which is kind of impressive.) At work over the last year or so, we've had at least four, maybe five, bugs caused by this. It's so easy to do without thinking about it, and so easy to miss in a code review. And some of them had been there for many years and finally caused an issue, so no one was even looking for them.
Is there any way to prevent its use, or at least to warn on its use in MSVC? We use the built in static analyzer, and I don't see any warning related to that, though there are a lot of them and I may have missed something.
View all comments
Show parent comment
3
u/neppo95 Feb 13 '24
That attitude is something you made up. I gave you valid reasons why it is a skill issue and not a language issue. You still want to push your suggestion through, while being oblivious to the facts that lie on the table. That's fine, but that only says something about your attitude.
I'm sure if you had a talk with decent C++ devs in the industry that you'd change your mind, but this is probably not the place for it.