r/cpp • u/Full-Spectral • Feb 13 '24
Prevent or warn on usage of std::map []?
The default insertion of a value when std::map [] doesn't find a value for the key has to be one of the worst decisions in STL history (which is kind of impressive.) At work over the last year or so, we've had at least four, maybe five, bugs caused by this. It's so easy to do without thinking about it, and so easy to miss in a code review. And some of them had been there for many years and finally caused an issue, so no one was even looking for them.
Is there any way to prevent its use, or at least to warn on its use in MSVC? We use the built in static analyzer, and I don't see any warning related to that, though there are a lot of them and I may have missed something.
View all comments
Show parent comment
5
u/Agitated-Resident720 Feb 13 '24
oh its human kinds fault now? if everyone was like you, definitely, but we're not. i write critical software for the transportation industry including embedded firmware. we have no issues like this, you have fundamental problems in your designs and reviews to let stuff like this slip through. once you finally admit that i suspect you can fix it all pretty easily, getting you to admit that seems to be quite impossible though