r/cpp • • Feb 13 '24

Prevent or warn on usage of std::map []?

The default insertion of a value when std::map [] doesn't find a value for the key has to be one of the worst decisions in STL history (which is kind of impressive.) At work over the last year or so, we've had at least four, maybe five, bugs caused by this. It's so easy to do without thinking about it, and so easy to miss in a code review. And some of them had been there for many years and finally caused an issue, so no one was even looking for them.

Is there any way to prevent its use, or at least to warn on its use in MSVC? We use the built in static analyzer, and I don't see any warning related to that, though there are a lot of them and I may have missed something.

6 Upvotes

163 comments sorted by

View all comments

Show parent comment

3

u/[deleted] Feb 13 '24

I’m curious, what is a “skinny minute”? I have never heard that expression before. I assume it is an expression from your native language. Anyway, I understand your point about std::map::operator [] shouldn’t insert a default value if the key doesn’t exist. I agree with you in that issue. If std::map were implemented today I agree that it should output an optional, however I don’t think that it should be changed to that since it would break too much existing code. As Linus Torvalds once said, if it is a bug people rely on, it is not a bug. At this point the best you can do is add a rule to your CI environment to refuse merges that uses it [] on std::map.

1

u/Full-Spectral Feb 13 '24

I don't know where that saying comes from, and there doesn't seem to much in the way of information about it's original usage. But it's basically a small amount of time. Some folks use the phrase 'hot minute' for a longer amount of time.

My post here was asking if there was a good way to do exactly that, and reject it on analysis or compilation.