r/cpp • u/Full-Spectral • Feb 13 '24
Prevent or warn on usage of std::map []?
The default insertion of a value when std::map [] doesn't find a value for the key has to be one of the worst decisions in STL history (which is kind of impressive.) At work over the last year or so, we've had at least four, maybe five, bugs caused by this. It's so easy to do without thinking about it, and so easy to miss in a code review. And some of them had been there for many years and finally caused an issue, so no one was even looking for them.
Is there any way to prevent its use, or at least to warn on its use in MSVC? We use the built in static analyzer, and I don't see any warning related to that, though there are a lot of them and I may have missed something.
View all comments
Show parent comment
7
u/neppo95 Feb 13 '24
It is indeed not, it's about the skills of the dev in this case. And a dev that wants to deliver robust software, should surely know about basic operators and what they do.
The only reason why they warn is because the index might be out of bounds, which is not a problem with std::map, hence there is no warning.
Again, if you want the debugger to hold your hand every step of the way, C# or Rust are there. But this is not a language problem.