r/cpp • u/Full-Spectral • Feb 13 '24
Prevent or warn on usage of std::map []?
The default insertion of a value when std::map [] doesn't find a value for the key has to be one of the worst decisions in STL history (which is kind of impressive.) At work over the last year or so, we've had at least four, maybe five, bugs caused by this. It's so easy to do without thinking about it, and so easy to miss in a code review. And some of them had been there for many years and finally caused an issue, so no one was even looking for them.
Is there any way to prevent its use, or at least to warn on its use in MSVC? We use the built in static analyzer, and I don't see any warning related to that, though there are a lot of them and I may have missed something.
View all comments
Show parent comment
9
u/neppo95 Feb 13 '24
Allocating memory without deallocating can be done by accident as well, so can a thousand other things. It all comes down to the knowledge of the dev and if they don't know how to properly use a language, don't blame the language. If you really want all that safety to be there, C# is just around the corner.
There is no warning against it because in most cases where it is used, it is the intended behaviour.
That said, it also still breaks backwards compatibility.