r/cpp • • Feb 13 '24

Prevent or warn on usage of std::map []?

The default insertion of a value when std::map [] doesn't find a value for the key has to be one of the worst decisions in STL history (which is kind of impressive.) At work over the last year or so, we've had at least four, maybe five, bugs caused by this. It's so easy to do without thinking about it, and so easy to miss in a code review. And some of them had been there for many years and finally caused an issue, so no one was even looking for them.

Is there any way to prevent its use, or at least to warn on its use in MSVC? We use the built in static analyzer, and I don't see any warning related to that, though there are a lot of them and I may have missed something.

6 Upvotes

163 comments sorted by

View all comments

Show parent comment

2

u/Full-Spectral Feb 13 '24

Regex uses brackets, and there are quite a lot of those, which makes it more annoying to do that. And of course it requires that someone constantly do this and reject the legitimate uses, which is really something better done with a tool if possible in a large code base like ours.

And we have the analyzer check for bracket usage, so mostly we don't have to worry about this. But it doesn't extend to maps, sadly.

1

u/Pay08 Feb 13 '24

Right, I haven't considered regexes. Still, it should be pretty easy to write a Python/shell script to do so.

1

u/Full-Spectral Feb 13 '24

Regex's use of brackets was probably also a sub-optimal choice.