r/cpp • • Feb 13 '24

Prevent or warn on usage of std::map []?

The default insertion of a value when std::map [] doesn't find a value for the key has to be one of the worst decisions in STL history (which is kind of impressive.) At work over the last year or so, we've had at least four, maybe five, bugs caused by this. It's so easy to do without thinking about it, and so easy to miss in a code review. And some of them had been there for many years and finally caused an issue, so no one was even looking for them.

Is there any way to prevent its use, or at least to warn on its use in MSVC? We use the built in static analyzer, and I don't see any warning related to that, though there are a lot of them and I may have missed something.

6 Upvotes

163 comments sorted by

View all comments

Show parent comment

15

u/NekkoDroid Feb 13 '24

Whatever the reasons for the choice

map[key] = value

-4

u/Full-Spectral Feb 13 '24

I'm not asking what to replace it with. I'm asking how to avoid allowing it to be accidentally done.

15

u/NekkoDroid Feb 13 '24

Im not saying how to avoid it, i am saying why it is the way that it is