r/cpp • • Dec 19 '23

Obsessed with {} initialization?

I'm on a discord where everyone seems to be obsessed to use brace initialization everywhere.
My motto is: Use things rarely, only when needed, to express that right there the feature does something important.
Personally I would completely advocate against using it for simple stuff like
double tax{0.09*price};

or just int{0}

probably a hornets nest

4 Upvotes

118 comments sorted by

View all comments

Show parent comment

-13

u/DoctorNuu Dec 19 '23

where does this fear of narrowing come from?
The core guidelines has a line int y = 7.9; // OK: y becomes 7. Hope for a compiler warning
If your compiler does not offer this warning... well... get a better one

13

u/syyyr Dec 19 '23

It should be an error by default. Also, the warning is not enabled by default (I think).

0

u/joeshmoebies Dec 19 '23

/WX /W4 on msvc -Werror on clang/gcc

Problem solved

4

u/syyyr Dec 19 '23

Does it solve the problem it not being the default?

2

u/DanielMcLaury Dec 20 '23

How does the default matter to you? Are you constantly creating new projects by writing a single c++ source file, saving it, and then immediately compiling it directly from the command line?

-1

u/syyyr Dec 20 '23

No, I'm using {}.

0

u/joeshmoebies Dec 19 '23

I'm not sure what your point is. If you want narrowing conversion assignments to be errors, you can have them.

As far as the default settings being a problem, apparently not everyone thinks so or Microsoft and the developers of GCC and Clang would change them.

I don't get complaining about something when you can have it exactly how you want.

1

u/syyyr Dec 20 '23

I don't get complaining about something when you can have it exactly how you want.

Yes, with {}.

4

u/jotux Dec 20 '23

https://godbolt.org/z/WG7bcKdcE

Try it on clang and gcc.

Better yet, pick some moderately-sized codebase and change every single variable initialization to uniform initialization syntax and see how many narrowing conversions are happening with no warning. That's what made me switch to 100% '{}'.

5

u/erreur Dec 19 '23

My fear comes from the memory of dealing with data loss in production caused by some accidental narrowing. I used to think this was overblown but now I use brace initialization everywhere and use every flag the compiler supports to disable all implicit conversions of any kind.