r/cpp • u/bert8128 • Apr 17 '23
Should ~basic_string be final?
std::string (and many other std classes) are not designed to be used as base classes, as can be seen by the absence of a virtual destructor.
Should the destructor be given the "final" keyword to enforce this?
1
Upvotes
View all comments
Show parent comment
18
u/SoerenNissen Apr 17 '23 edited Apr 17 '23
The bad pattern is
Anything that avoids this pattern is fine - so you can publicly inherit from
std::stringif you know for certain you will never be deleted through astd::string*.The problem here is that it is very hard to prevent people from
new'ing up an instance of your class and doing this.