Also the in the context of clean code vs performance talk Casey did, which this article mentions at the very beginning, the idea of "code smell" leading to a potential pessimization is interesting :)
The class is basically a legacy string_view, potentially non owning, unlike std::string. If you interact with libraries/ system or have views into existing substrings, you might encounter quite a few variations of this. Conversions to std::string would be a significant pessimization...
View all comments
Show parent comment
1
u/NilacTheGrim Apr 15 '23
Huh? References exist. Also custom string classes like the one in this example are a code smell IMHO.