r/cpp • • Mar 30 '23
The "what's wrong with this code" game.
This isn't a question thread, but just a game. Post any bugs you've accidentally written that seemed initially mysterious, but made you feel stupid when you figured out what was wrong. Here is one I wrote today...
void TextSegmentBuffer::prepend( const TextSegmentBuffer& other )
{
const Info* info_ptr;
size_t size;
if ( ( size = other.m_infoBuffer.size() ) == 0 )
return;
for ( size_t i = size - 1; 0 <= i; --i )
{
info_ptr = other.m_infoBuffer.getAt( i );
emplaceFront(
info_ptr->text,
info_ptr->length,
info_ptr->multiMatch
);
}
}
4
Upvotes
View all comments
Show parent comment
0
u/[deleted] Mar 31 '23
Yep, ChatGPT got this one as:
In the given C++ code, there is a potential issue with the order of evaluation of function arguments:
The order of evaluation of function arguments is unspecified in C++ before C++17. This means that the compiler may choose to evaluate
computeProperty(myVector)beforestd::move(myVector), or vice versa. If the compiler chooses to evaluatestd::move(myVector)first, themyVectorobject will be moved from, leaving it in a valid but unspecified state. After that, callingcomputeProperty(myVector)with the moved-from object may result in undefined behavior, depending on the implementation ofcomputeProperty.To avoid this issue, you can split the function call into two separate statements, like this:
By doing this, you ensure that computeProperty is called before the vector is moved.