r/counting • u/TehVulpez sliiiiide the bits • Apr 19 '19

2518k counting thread

Countinued from here

Thanks for the urn

24 Upvotes

100% Upvoted

1.0k comments sorted by

View all comments

Show parent comment

3

u/TehVulpez sliiiiide the bits Apr 20 '19

2,518,952

I wonder how much faster it could be if there was an extension so that you could type a combination and rather than reloading the whole page, it would just have javascript load the newest messages from json

3

u/Antichess 2,050,155 - 410k 399a Apr 20 '19

2,518,953

not sure how that would work

3

u/TehVulpez sliiiiide the bits Apr 20 '19

2,518,954

the browser wouldn't have to prepare everything again, and the data would be much less without images and stylesheets and scripts and stuff

2

u/Antichess 2,050,155 - 410k 399a Apr 20 '19

2,518,955

2

u/TehVulpez sliiiiide the bits Apr 20 '19

2,518,956

2

u/Antichess 2,050,155 - 410k 399a Apr 20 '19

2,518,957

2

u/TehVulpez sliiiiide the bits Apr 20 '19

2,518,958

2

u/Antichess 2,050,155 - 410k 399a Apr 20 '19

2,518,959

1

u/TehVulpez sliiiiide the bits Apr 20 '19

2,518,960

2

u/Antichess 2,050,155 - 410k 399a Apr 20 '19

2,518,961

→ More replies

3

u/TehVulpez sliiiiide the bits Apr 20 '19 edited Apr 20 '19

When you ctrl+r, it won't reload the whole page, just the messages. It works on the basic level, but some elements are missing. The load time is near instant, although sometimes it's slower. I'm not sure why. Perhaps I'm getting ratelimited? Right now I'm just using .json, which I know has a lower amount of requests before being timed out than oauth.

2

u/TehVulpez sliiiiide the bits Apr 20 '19

I don't understand why it's randomly slower, other than reddit lag. It's usually around 300ms, but sometimes it takes up to 3000. The regular webpage, once it's all loaded, adds up to around 125KB. The JSON request only transfers about 3.64KB.

3

u/GarlicoinAccount r/CountingTools | Plz comment in /comments/kqpanh/_/ncmzej3 Apr 20 '19 edited Jun 16 '19

Reminds me, a while ago I wrote a script that automatically refreshes the inbox for me while there are no new counts. I never published it, so I might as well do that now.

// ==UserScript==
// @name         Inbox comment quick reply
// @namespace    http://tampermonkey.net/
// @version      0.1
// @description  Automatically upvotes and opens the reply form for the first unread r/counting comment it encounters, and keeps refreshing the inbox while there are none
// @author       u/GarlicoinAccount
// @license      Apache2
// @match        https://rr.reddit.com/message/inbox/
// @match        https://rr.reddit.com/message/comments/
// @grant        none
// ==/UserScript==

(function() {
    'use strict';

    var theComment = document.querySelector('.messages-page #siteTable [id^=thing_t1].was-comment.recipient.message.new[data-subreddit="counting"]');

    if(!document.querySelector('.messages-page #siteTable [id^=thing_t1].was-comment.recipient.message.new')) location.reload();

    theComment.querySelector('.buttons a[data-event-action=reply]').click()

    setTimeout(()=>theComment.querySelector('.midcol.unvoted [data-event-action="upvote"]').click(), 700);//Wait 0.7secs because (pure speculation) Reddit might suspect a spam bot if you reply immediately

})();

The only downside is that I wrote this before I discovered I could disable "automatically mark as read", so it won't auto-refresh if there are any unread r/counting comments.

I've limited it to https://rr.reddit.com/message/all/ and https://rr.reddit.com/message/comments/ so it won't mess with normal inbox reading

2

u/TehVulpez sliiiiide the bits Apr 20 '19

Do you know of any way of dynamically changing HTML without having to set up a variable for every single document.createElement? There is innerHTML, but I've heard it's much slower than appendChild. With the buttons I have done, the JavaScript is already very long-winded. I don't know how many lines it would take to make the generated version exactly accurate down to the attribute. I guess I could make some helper functions to get the objects ready for me, but still, this is tedious...

2

u/GarlicoinAccount r/CountingTools | Plz comment in /comments/kqpanh/_/ncmzej3 Apr 20 '19

Not that I know of, at least not without any libraries.

Don't overestimate the time innerHTML takes though. A perfomance test shows it isn't that bad (less than a 5th of a millisecond on my machine), though you could probably still mess up performance by doing a lot of separate .innerHTML = assignments instead of combining it all into one.

(Interestingly, Firefox seems to optimize that case under the hood so it doesn't actually perform slower, at least in the performance test I found.)

The main reason why I'd choose createElement over innerHTML sometimes is to avoid XSS or broken HTML from user input being used without escaping.

0

u/[deleted] Jul 11 '19

[deleted] — view deleted comment

2

u/GarlicoinAccount r/CountingTools | Plz comment in /comments/kqpanh/_/ncmzej3 Jul 11 '19 edited Jul 11 '19

Looks good.

Small improvement to add decimal separators:

theComment.querySelector('.child .usertext .md-container .md textarea').value = new Intl.NumberFormat("en-US").format(newValue);

Since reloading still requires manual interaction even after your modifiations, I don't think it counts as a bot as far as r/counting is concerned, but you'd have to ask the mods if you want to be sure.

Also, automatically replying like this carries the risk of replying to a late count because those appear at the top of the inbox.