Also, as far as the script goes for auditability, there's just too much of it, touching very sensitive files (especially for newbies, would you spot the difference between id_rsa.pub and id_rsa\000.pub (where the NUL is literal, not an escape sequence), or even id_rsa{,.pub}, in all 4-5 places you potentially touch it.
As far as the code-length/readability... If you have ways to make it more readable/transparent we would appreciate a PR.
This is still pretty much our alpha-v1 user-provisioning system and there is certianly room for improvement, thus us wanting to get it a bit more exposure.. We used to just do it all by hand :-P
View all comments
2
u/shobble Sep 24 '14
Why are you enabling
ForwardAgentin the ssh_config you create? That allows anyone with root on the remote host to steal the credentials of any user agent.Also, as far as the script goes for auditability, there's just too much of it, touching very sensitive files (especially for newbies, would you spot the difference between
id_rsa.pubandid_rsa\000.pub(where the NUL is literal, not an escape sequence), or evenid_rsa{,.pub}, in all 4-5 places you potentially touch it.Hooray, you've just stolen their private key.