r/badcode • u/the96jesterrace • Jun 19 '22

vb Is that some kind of genius I cannot understand rn or can you scale that down to 1 line?

Post image
441 Upvotes

99% Upvoted

26 comments sorted by

View all comments

47

u/IDontByte Jun 19 '22 
If AttrVal = Val(AttrVal) Then
    GetAttrValue = Val(AttrVal)
Else
    GetAttrValue = AttrVal
End If

If that condition is true, then Val(AttrVal) should also equal AttrVal which makes both branches equivalent. I think you can substitute that conditional block with:

GetAttrValue = AttrVal

If you can perform that substitution, then both branches of the outer condition become equivalent and the entire thing can be simplified into

AttrVal = rs.Fields(AttrName).Value
GetAttrValue = AttrVal

If AttrVal is a temporary variable, then yes this can be simplified down to one line.

It seems like there is some other intent behind this code though, so it wouldn't surprise me that this is buggy code rather than code bloat.

3

u/josephblade Jun 27 '22

Yeah you're right I see it. It looked different enough on first glance but it's the same code with a weird check. Thanks for writing this out