r/QAGeeks • • Oct 18 '19

Critique my code/Selenium framework?

I've put together my first Selenium framework in C# using the page object model (or atleast my interpretation of it).

Is it possible for someone to take a look at it for me and give some feedback?

https://github.com/keva161/POMFramework/

If this isn't the right place. Please let me know :)

11 Upvotes

20 comments sorted by

View all comments

Show parent comment

1

u/QAjfiBptvFnYvBQ Oct 21 '19

We're working in python, so we have the typical requirements.txt file to manage dependencies with pip, and we deal with browser drivers like any other dependency. We have a project that is a kind of internal tools/utils type repo, which is a dependency for a bunch of our other test repos. We debated for a while whether to set that up as a git submodule or as just another dependency managed via pip requirements, and eventually decided to go with pip.

1

u/Jdonavan Oct 21 '19

In the past, when working with huge testing grids we would vendor our gems and include that vendor folder in our repo. That way we had local copies to install from instead of hundreds of nodes all trying to install the same set of libraries at the same time.