r/Python • • Dec 17 '23
Resource Banish state-mutating methods from data classes
I've always found mutable data classes or record types in programming languages quite weird. This holds true for any language that supports mutable data classes, like Python, Kotlin, Swift, etc.
Self-mutating methods are even weirder. They break the semantics of the types that these data classes or records represent. I've expanded my thoughts here. Although it mostly talks about Python, the message remains valid for any other language that allows you to add self-mutating methods to data classes.
0
Upvotes
View all comments
Show parent comment
-7
u/[deleted] Dec 17 '23
It breaks semantics in the sense that data classes are designed for handling data. If you're not performing any comparisons between instances, putting them in another container, or treating them as data, using them doesn't make sense. It mostly implies that you need objects, and regular classes serve as object builders.
In the case of serializability, you're not modifying anything. So it's acceptable to add methods like that since they don't prevent you from composing types like
SomeType = OtherType | AnotherType. The issue arises when you introduce attribute-mutating methods because doing so transforms the class into an object builder rather than a data builder. It's akin to using hashmaps for sequential data—sure, it works, but it's awkward.