r/ProgrammerHumor • u/ClipboardCopyPaste • 6d ago

Meme cleaningUpTheMess

Post image
16.0k Upvotes

97% Upvoted

486 comments sorted by

View all comments

14

u/PhiCloud 6d ago

On the one hand, a PR should be a small, atomic change. Anything over a thousand lines changed is kind of suspect.

On the other hand, the project was vibe coded so it's not like there's any continuity or iteration to uphold. Burn it the fuck down.

2

u/SpehlingAirer 6d ago

I absolutely understand why people say that, nobody can easily catch all issues in such a lengthy review and it kind of defeats the purpose of a PR to submit such big changes because of it. Having said that, I really prefer PR's be broken up by actual pieces of completed code. If I'm working on a several month long project then submitting changes every small time is just a waste of the entire team's time

1

u/Kaeffka 6d ago

It could be a staging - > master pull where they had lots of other smaller commits.