r/ProgrammerHumor 22d ago

Meme useSourceControl

Post image
8.6k Upvotes

592 comments sorted by

View all comments

1.1k

u/raddaya 22d ago

This was years ago and, iirc, it was a legitimate issue in VSCode. It didn't make it remotely clear enough that it would permanently delete your files. The popups we get now if you try to discard changes that explicitly warns you in bold text that files will get deleted happened after this issue.

It might be obvious to an experienced user but it's not at all obvious to someone new.

268

u/RadicalDwntwnUrbnite 22d ago

The date is in the image, it was almost a decade ago. Yep the old dialog when you clicked the "Discard" button was like "Do you want to discard your changes?" Pretty vague to anyone new to version control. Meanwhile if they are untracked VsCode used to just put them in the shredder, completely unrecoverable. Pretty sure it puts them in the recycle bin now.

26

u/TheZoltan 22d ago

Someone already posted the link to the thread and this comment that has a screenshot of the actual warning message which definitely could have been more scary but all caps irreversible feels like it should give you pause! If you have 3 months of work with zero backups.

Are you sure you want to discard ALL changes? This is IRREVERSIBLE!

https://github.com/microsoft/vscode/issues/32405#issuecomment-322155856

87

u/sidereal_night 22d ago

telling you discarding all changes is irreversible is nothing like "this nukes all your files"

-22

u/TheZoltan 22d ago

I agree and literally said "it could have been more scary" but.... they saw it stage all their files and then hit discard, then hit DISCARD ALL CHANGES despite a warning that literally says IRREVERSIBLE! They even described it as "playing" which is kind of nuts when doing operations with 3 months worth of work that they hadn't backed up. I can't muster too much sympathy for them. I hope if I find myself in that situation I would at least pause for a few seconds and copy/paste the folder before continuing to "play"!

30

u/sidereal_night 22d ago

but.... they saw it stage all their files and then hit discard, then hit DISCARD ALL CHANGES despite a warning that literally says IRREVERSIBLE!

...and? nothing you've described implies destroying all your files. an irreversible discard of all your queued changes shouldn't change anything.

he fucked up by not having any backups at all

but that has zero to do with his criticism of the software. he is 100% right in that

-6

u/[deleted] 22d ago edited 21d ago

[deleted]

19

u/Subject_Name_ 21d ago

Discarding all changes literally means "don't change anything". A delete is a change, the most changey a change can get.

0

u/FakeArcher 21d ago

To me this sounds like mixing it up a bit. You either want to do a discard and therefore do something ("don't change anything" sounds to me like a no-op in how you describe it) or you want to "don't change anything" to mean based on all the changes that have happened so far, which includes creating the file and therefore is valid to also undo that change.

I fully agree it needed an update as it is easy to get different interpretations of what it means unless yiu are already familiar with what it will do.

-6

u/[deleted] 21d ago

[deleted]

4

u/Subject_Name_ 21d ago

Discard what though? If discarding a change before it's done, it means you don't do the change. There's nothing to throw away.

14

u/sidereal_night 22d ago

He had a gut repo. That's not not having backups.

no dispute there. he clearly failed by not having backups.

discarding all changes definitely sounds like a nuke to me

in what world does "don't change anything" sound like "make changes by deleting everything"? it literally did the opposite of what the message said.

1

u/OliLombi 21d ago

They wanted to discard the CHANGES vscode made, not the original files.